Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 208393006: Have SkTArray explicitly call default constructors. (Closed)

Created:
6 years, 9 months ago by bungeman-skia
Modified:
6 years, 9 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com, reed1
Visibility:
Public.

Description

Have SkTArray state that it default-initializes. The current comments in SkTArray lead one to believe that it is default constructing all types. However, it is not calling the default constructor for primitive types, it is actually default-initializing. R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=13909

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M include/core/SkTArray.h View 1 3 chunks +5 lines, -5 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
bungeman-skia
6 years, 9 months ago (2014-03-21 20:43:14 UTC) #1
bsalomon
Is this something you need? I'm not necessarily opposed but if we don't need this ...
6 years, 9 months ago (2014-03-24 13:16:57 UTC) #2
bungeman-skia
On 2014/03/24 13:16:57, bsalomon wrote: > Is this something you need? I'm not necessarily opposed ...
6 years, 9 months ago (2014-03-24 13:56:56 UTC) #3
bungeman-skia
New patch, just change the comments so that they reflect what the code actually does. ...
6 years, 9 months ago (2014-03-24 15:45:48 UTC) #4
bsalomon
lgtm
6 years, 9 months ago (2014-03-24 15:49:57 UTC) #5
bungeman-skia
6 years, 9 months ago (2014-03-24 15:55:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r13909 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698