Source/core/rendering/RenderBoxModelObject.cpp - Issue 208393004: Fix zero height root renderer with background image painting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBoxModelObject.cpp

Issue 208393004: Fix zero height root renderer with background image painting (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/backgrounds/root-with-generated-background-and-no-height-expected.html ('K') | « LayoutTests/fast/backgrounds/root-with-generated-background-and-no-height-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderBoxModelObject.cpp

diff --git a/Source/core/rendering/RenderBoxModelObject.cpp b/Source/core/rendering/RenderBoxModelObject.cpp

index 22b207cd6bf25dda74fc73e9fb14a866c2e18c48..93c7f2e6361c42bca2c1f4e55d1a1a486d777cc0 100644

--- a/Source/core/rendering/RenderBoxModelObject.cpp

+++ b/Source/core/rendering/RenderBoxModelObject.cpp

@@ -664,7 +664,7 @@ void RenderBoxModelObject::paintFillLayerExtended(const PaintInfo& paintInfo, co

if (!bgLayer->next()) {

IntRect backgroundRect(pixelSnappedIntRect(scrolledPaintRect));

bool boxShadowShouldBeAppliedToBackground = this->boxShadowShouldBeAppliedToBackground(bleedAvoidance, box);

- if (boxShadowShouldBeAppliedToBackground || !shouldPaintBackgroundImage || !bgLayer->hasOpaqueImage(this) || !bgLayer->hasRepeatXY()) {

+ if (boxShadowShouldBeAppliedToBackground || !shouldPaintBackgroundImage || !bgLayer->hasOpaqueImage(this) || !bgLayer->hasRepeatXY() || (isOpaqueRoot && !toRenderBox(this)->height())) {

if (!boxShadowShouldBeAppliedToBackground)

backgroundRect.intersect(paintInfo.rect);