MacViews: Fix WidgetObserverTest.WidgetBoundsChangedNative after r400463

MacViews: Fix WidgetObserverTest.WidgetBoundsChangedNative after r400463

If a Widget bounds is outside the work area when shown, OSX will move it
inside when the widget is Show()n.

r400463 added a handler for -[NSWindowDelegate windowDidMove:], invoking
OnNativeWidgetMove(). There was only test coverage for movement done in
combination with a resize, so this wasn't noticed earlier.

WidgetBoundsChangedNative regressed on Mac, because the Widget now
correctly observes the movement into the work area that OSX enforces. To
cover the same codepaths as before, use an origin that's inside the work
area, rather than (0,0).

Add coverage that would have picked up the the missing
OnNativeWidgetMove() call. Currently this fails on Mus, but not other
native widget types.

BUG=621419
Committed: https://crrev.com/061e7a03a36519fc21c5987e84709310b505244b
Cr-Commit-Position: refs/heads/master@{#401752}

[tapted, 2016-06-23 05:04:03]

Description was changed from

==========
MacViews: Fix WidgetObserverTest.WidgetBoundsChangedNative after r400463

If a Widget bounds is outside the work area when shown, OSX will move it
inside.

r400463 added a handler for -[NSWindowDelegate windowDidMove:], invoking
OnNativeWidgetMove(). There was only test coverage for movement done in
combination with a resize, so add some more to cover OnNativeWidgetMove().

WidgetBoundsChangedNative regressed on Mac, because the Widget now
correctly observes the movement into the work area that OSX enforces.

BUG=621419
==========

to

==========
MacViews: Fix WidgetObserverTest.WidgetBoundsChangedNative after r400463

If a Widget bounds is outside the work area when shown, OSX will move it
inside when the widget is Show()n.

r400463 added a handler for -[NSWindowDelegate windowDidMove:], invoking
OnNativeWidgetMove(). There was only test coverage for movement done in
combination with a resize, so add some more to cover
OnNativeWidgetMove().

WidgetBoundsChangedNative regressed on Mac, because the Widget now
correctly observes the movement into the work area that OSX enforces. To
cover the same codepaths, use an origin that's inside the work area,
rather than (0,0), but add coverage that would have picked up the the
missing OnNativeWidgetMove() call.

BUG=621419
==========

[tapted, 2016-06-23 05:28:08]

Description was changed from

==========
MacViews: Fix WidgetObserverTest.WidgetBoundsChangedNative after r400463

If a Widget bounds is outside the work area when shown, OSX will move it
inside when the widget is Show()n.

r400463 added a handler for -[NSWindowDelegate windowDidMove:], invoking
OnNativeWidgetMove(). There was only test coverage for movement done in
combination with a resize, so add some more to cover
OnNativeWidgetMove().

WidgetBoundsChangedNative regressed on Mac, because the Widget now
correctly observes the movement into the work area that OSX enforces. To
cover the same codepaths, use an origin that's inside the work area,
rather than (0,0), but add coverage that would have picked up the the
missing OnNativeWidgetMove() call.

BUG=621419
==========

to

==========
MacViews: Fix WidgetObserverTest.WidgetBoundsChangedNative after r400463

If a Widget bounds is outside the work area when shown, OSX will move it
inside when the widget is Show()n.

r400463 added a handler for -[NSWindowDelegate windowDidMove:], invoking
OnNativeWidgetMove(). There was only test coverage for movement done in
combination with a resize, so add some more to cover
OnNativeWidgetMove().

WidgetBoundsChangedNative regressed on Mac, because the Widget now
correctly observes the movement into the work area that OSX enforces. To
cover the same codepaths as before, use an origin that's inside the work
area, rather than (0,0).

Add coverage that would have picked up the the missing
OnNativeWidgetMove() call. Currently this fails on Mus.

BUG=621419
==========

[tapted, 2016-06-23 05:29:22]

Description was changed from

==========
MacViews: Fix WidgetObserverTest.WidgetBoundsChangedNative after r400463

If a Widget bounds is outside the work area when shown, OSX will move it
inside when the widget is Show()n.

r400463 added a handler for -[NSWindowDelegate windowDidMove:], invoking
OnNativeWidgetMove(). There was only test coverage for movement done in
combination with a resize, so add some more to cover
OnNativeWidgetMove().

WidgetBoundsChangedNative regressed on Mac, because the Widget now
correctly observes the movement into the work area that OSX enforces. To
cover the same codepaths as before, use an origin that's inside the work
area, rather than (0,0).

Add coverage that would have picked up the the missing
OnNativeWidgetMove() call. Currently this fails on Mus.

BUG=621419
==========

to

==========
MacViews: Fix WidgetObserverTest.WidgetBoundsChangedNative after r400463

If a Widget bounds is outside the work area when shown, OSX will move it
inside when the widget is Show()n.

r400463 added a handler for -[NSWindowDelegate windowDidMove:], invoking
OnNativeWidgetMove(). There was only test coverage for movement done in
combination with a resize, so add some more to cover
OnNativeWidgetMove().

WidgetBoundsChangedNative regressed on Mac, because the Widget now
correctly observes the movement into the work area that OSX enforces. To
cover the same codepaths as before, use an origin that's inside the work
area, rather than (0,0).

Add coverage that would have picked up the the missing
OnNativeWidgetMove() call. Currently this fails on Mus, but not other
native widget types.

BUG=621419
==========

[tapted, 2016-06-23 05:29:22]

tapted@chromium.org changed reviewers:
+ sky@chromium.org

[tapted, 2016-06-23 05:30:17]

Description was changed from

==========
MacViews: Fix WidgetObserverTest.WidgetBoundsChangedNative after r400463

If a Widget bounds is outside the work area when shown, OSX will move it
inside when the widget is Show()n.

r400463 added a handler for -[NSWindowDelegate windowDidMove:], invoking
OnNativeWidgetMove(). There was only test coverage for movement done in
combination with a resize, so add some more to cover
OnNativeWidgetMove().

WidgetBoundsChangedNative regressed on Mac, because the Widget now
correctly observes the movement into the work area that OSX enforces. To
cover the same codepaths as before, use an origin that's inside the work
area, rather than (0,0).

Add coverage that would have picked up the the missing
OnNativeWidgetMove() call. Currently this fails on Mus, but not other
native widget types.

BUG=621419
==========

to

==========
MacViews: Fix WidgetObserverTest.WidgetBoundsChangedNative after r400463

If a Widget bounds is outside the work area when shown, OSX will move it
inside when the widget is Show()n.

r400463 added a handler for -[NSWindowDelegate windowDidMove:], invoking
OnNativeWidgetMove(). There was only test coverage for movement done in
combination with a resize, so this wasn't noticed earlier.

WidgetBoundsChangedNative regressed on Mac, because the Widget now
correctly observes the movement into the work area that OSX enforces. To
cover the same codepaths as before, use an origin that's inside the work
area, rather than (0,0).

Add coverage that would have picked up the the missing
OnNativeWidgetMove() call. Currently this fails on Mus, but not other
native widget types.

BUG=621419
==========

[tapted, 2016-06-23 12:17:01]

Hi sky, please take a look. My goal is to get views_unittests running on all the
mac bots this week (hopefully without having to disable stuff) -- I've put it
off for too long!

[sky, 2016-06-23 15:50:27]

LGTM

[tapted, 2016-06-23 23:16:00]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2016-06-23 23:16:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2083923002/60001

[commit-bot: I haz the power, 2016-06-23 23:22:11]

Description was changed from

==========
MacViews: Fix WidgetObserverTest.WidgetBoundsChangedNative after r400463

If a Widget bounds is outside the work area when shown, OSX will move it
inside when the widget is Show()n.

r400463 added a handler for -[NSWindowDelegate windowDidMove:], invoking
OnNativeWidgetMove(). There was only test coverage for movement done in
combination with a resize, so this wasn't noticed earlier.

WidgetBoundsChangedNative regressed on Mac, because the Widget now
correctly observes the movement into the work area that OSX enforces. To
cover the same codepaths as before, use an origin that's inside the work
area, rather than (0,0).

Add coverage that would have picked up the the missing
OnNativeWidgetMove() call. Currently this fails on Mus, but not other
native widget types.

BUG=621419
==========

to

==========
MacViews: Fix WidgetObserverTest.WidgetBoundsChangedNative after r400463

If a Widget bounds is outside the work area when shown, OSX will move it
inside when the widget is Show()n.

r400463 added a handler for -[NSWindowDelegate windowDidMove:], invoking
OnNativeWidgetMove(). There was only test coverage for movement done in
combination with a resize, so this wasn't noticed earlier.

WidgetBoundsChangedNative regressed on Mac, because the Widget now
correctly observes the movement into the work area that OSX enforces. To
cover the same codepaths as before, use an origin that's inside the work
area, rather than (0,0).

Add coverage that would have picked up the the missing
OnNativeWidgetMove() call. Currently this fails on Mus, but not other
native widget types.

BUG=621419
==========

[commit-bot: I haz the power, 2016-06-23 23:22:12]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-23 23:24:37]

Description was changed from

==========
MacViews: Fix WidgetObserverTest.WidgetBoundsChangedNative after r400463

If a Widget bounds is outside the work area when shown, OSX will move it
inside when the widget is Show()n.

r400463 added a handler for -[NSWindowDelegate windowDidMove:], invoking
OnNativeWidgetMove(). There was only test coverage for movement done in
combination with a resize, so this wasn't noticed earlier.

WidgetBoundsChangedNative regressed on Mac, because the Widget now
correctly observes the movement into the work area that OSX enforces. To
cover the same codepaths as before, use an origin that's inside the work
area, rather than (0,0).

Add coverage that would have picked up the the missing
OnNativeWidgetMove() call. Currently this fails on Mus, but not other
native widget types.

BUG=621419
==========

to

==========
MacViews: Fix WidgetObserverTest.WidgetBoundsChangedNative after r400463

If a Widget bounds is outside the work area when shown, OSX will move it
inside when the widget is Show()n.

r400463 added a handler for -[NSWindowDelegate windowDidMove:], invoking
OnNativeWidgetMove(). There was only test coverage for movement done in
combination with a resize, so this wasn't noticed earlier.

WidgetBoundsChangedNative regressed on Mac, because the Widget now
correctly observes the movement into the work area that OSX enforces. To
cover the same codepaths as before, use an origin that's inside the work
area, rather than (0,0).

Add coverage that would have picked up the the missing
OnNativeWidgetMove() call. Currently this fails on Mus, but not other
native widget types.

BUG=621419

Committed: https://crrev.com/061e7a03a36519fc21c5987e84709310b505244b
Cr-Commit-Position: refs/heads/master@{#401752}
==========

[commit-bot: I haz the power, 2016-06-23 23:24:38]

Patchset 4 (id:??) landed as
https://crrev.com/061e7a03a36519fc21c5987e84709310b505244b
Cr-Commit-Position: refs/heads/master@{#401752}