Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2083903002: [MD Settings] Allow editing autofill items from Google Payments. (Closed)

Created:
4 years, 6 months ago by hcarmona
Modified:
4 years, 6 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Settings] Allow editing autofill items from Google Payments. Also adds a "Google Payments" label to CCs and Addresses that come from Google Payments. Screenshot in Issue 607348. BUG=607347, 607348 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f0018ceaa583322e8732ef8bec460e82ff877918 Cr-Commit-Position: refs/heads/master@{#401473}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix margin and color #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -7 lines) Patch
M chrome/app/settings_strings.grdp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html View 1 3 chunks +19 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js View 5 chunks +22 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
hcarmona
PTAL
4 years, 6 months ago (2016-06-21 21:56:12 UTC) #5
dschuyler
lgtm https://codereview.chromium.org/2083903002/diff/20001/chrome/app/settings_strings.grdp File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/2083903002/diff/20001/chrome/app/settings_strings.grdp#newcode224 chrome/app/settings_strings.grdp:224: <message name="IDS_SETTINGS_GOOGLE_PAYMENTS" desc="Label used to differentiate when an ...
4 years, 6 months ago (2016-06-21 23:38:35 UTC) #6
hcarmona
Made a small change to CSS based on feedback on the screenshot. Rebased branches which ...
4 years, 6 months ago (2016-06-22 00:19:41 UTC) #7
dschuyler
SLGTM
4 years, 6 months ago (2016-06-22 23:00:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083903002/40001
4 years, 6 months ago (2016-06-22 23:59:55 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-23 00:08:44 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 00:13:22 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f0018ceaa583322e8732ef8bec460e82ff877918
Cr-Commit-Position: refs/heads/master@{#401473}

Powered by Google App Engine
This is Rietveld 408576698