Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2083893002: Move ChromeOS/Android checking for legacy protocol to build files. (Closed)

Created:
4 years, 6 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ChromeOS/Android checking for legacy protocol to build files. This allows for NaCl on ChromeOS to be detected and built with the old EDK protocol. BUG=604282 Committed: https://crrev.com/b6897550d500ebc5c2e9a863af03a6b4d3b12e28 Cr-Commit-Position: refs/heads/master@{#400894}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -12 lines) Patch
M mojo/edk/system/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/edk/system/channel.h View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/edk/system/channel.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M mojo/mojo_edk.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/mojo_edk_nacl.gyp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Anand Mistry (off Chromium)
4 years, 6 months ago (2016-06-21 01:53:16 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 6 months ago (2016-06-21 01:59:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083893002/1
4 years, 6 months ago (2016-06-21 03:50:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 04:48:36 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 04:52:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b6897550d500ebc5c2e9a863af03a6b4d3b12e28
Cr-Commit-Position: refs/heads/master@{#400894}

Powered by Google App Engine
This is Rietveld 408576698