Reject PaymentResponse.complete() promise on error.

Reject PaymentResponse.complete() promise on error.

If the user cancels the PaymentRequest UI by clicking on the Android
"back" button while the website is processing the transaction, then
website's complete() call should be rejected.

BUG=621767
Committed: https://crrev.com/3897d84540af80d6f88cc5ecc0b89d722ab366ae
Cr-Commit-Position: refs/heads/master@{#401110}

[please use gerrit instead, 2016-06-21 02:24:23]

rouslan@chromium.org changed reviewers:
+ mek@chromium.org

[please use gerrit instead, 2016-06-21 02:24:24]

mek@, ptal.

[Marijn Kruisselbrink, 2016-06-21 20:45:50]

lgtm I think.

Although I'm not sure I'm still following all the many states a PaymentRequest
can be in, and what that means for the various methods/members. Especially since
the state is effectively encoded in the presence/absence of a bunch of
ScriptPromiseResolvers and mojo connections it's pretty hard to follow what
states are valid, what transitions between those states can happen, etc... And
the implementation certainly seems to have way more states than the 3
(https://w3c.github.io/browser-payment-api/#state-transitions) the spec
mentions...

https://codereview.chromium.org/2083883003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right):

https://codereview.chromium.org/2083883003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:330: return
ScriptPromise::rejectWithDOMException(scriptState,
DOMException::create(InvalidStateError, "Request cancelled"));
It seems a bit odd that this throws a different exception than what would be
thrown in the (only different by race conditions) situation where the mojo
connection just happens to have closed right after complete() was called (in
that case OnError throws a SyntaxError). But maybe it's that SyntaxError that
doesn't really make sense?

Also is there a corresponding spec bug for this case? Although I'm not quite
clear on how much of the UI behavior is actually part of the spec and how much
is just up to user agents.

[please use gerrit instead, 2016-06-21 21:03:01]

Sending to cq.

https://codereview.chromium.org/2083883003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right):

https://codereview.chromium.org/2083883003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:330: return
ScriptPromise::rejectWithDOMException(scriptState,
DOMException::create(InvalidStateError, "Request cancelled"));
On 2016/06/21 20:45:50, Marijn Kruisselbrink wrote:
> It seems a bit odd that this throws a different exception than what would be
> thrown in the (only different by race conditions) situation where the mojo
> connection just happens to have closed right after complete() was called (in
> that case OnError throws a SyntaxError). But maybe it's that SyntaxError that
> doesn't really make sense?
> 
> Also is there a corresponding spec bug for this case? Although I'm not quite
> clear on how much of the UI behavior is actually part of the spec and how much
> is just up to user agents.

User cancelling the payment request does not appear anywhere in the spec. I will
bring it up with the editors. UI behavior is indeed up to user agents to
determine.

[please use gerrit instead, 2016-06-21 21:04:34]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2016-06-21 21:05:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2083883003/1

[commit-bot: I haz the power, 2016-06-21 21:18:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-21 21:19:53]

Description was changed from

==========
Reject PaymentResponse.complete() promise on error.

If the user cancels the PaymentRequest UI by clicking on the Android
"back" button while the website is processing the transaction, then
website's complete() call should be rejected.

BUG=621767
==========

to

==========
Reject PaymentResponse.complete() promise on error.

If the user cancels the PaymentRequest UI by clicking on the Android
"back" button while the website is processing the transaction, then
website's complete() call should be rejected.

BUG=621767

Committed: https://crrev.com/3897d84540af80d6f88cc5ecc0b89d722ab366ae
Cr-Commit-Position: refs/heads/master@{#401110}
==========

[commit-bot: I haz the power, 2016-06-21 21:19:54]

Patchset 1 (id:??) landed as
https://crrev.com/3897d84540af80d6f88cc5ecc0b89d722ab366ae
Cr-Commit-Position: refs/heads/master@{#401110}