Include file names in trace_turbo output

Include file names in trace_turbo output

The trace turbo output will overwrite itself when functions in different
files share the same name. Output files now have the form
`turbo-<function_name>:<opt_file_name>-<opt_phase>.suffix`.

R=ofrobots@google.com
BUG=

Committed: https://crrev.com/a53b9bf02f31e5647c37e0392afa19f74df1a3ba
Cr-Commit-Position: refs/heads/master@{#37199}

[ofrobots, 2016-06-22 16:46:44]

On 2016/06/22 03:02:21, mattloring wrote:

Shouldn't this new behviour kick in only when FLAG_trace_file_names is true? The
description for trace_file_names should be updated if so.

Does opt_file_name include the script basename or is it the full path? If it is
the full path, how are you dealing with slashes? If it is the basename, then the
underlying problem remains unsolved as neither script name nor function names
are guaranteed to be unique.

[ofrobots, 2016-06-22 16:47:13]

Description was changed from

==========
Include file names in trace_turbo output

The trace turbo output will overwrite itself when functions in different
files share the same name. Output files now have the form
`turbo-<function_name>:<opt_file_name>-<opt_phase>.suffix`.

R=ofrobots@google.com
BUG=
==========

to

==========
Include file names in trace_turbo output

The trace turbo output will overwrite itself when functions in different
files share the same name. Output files now have the form
`turbo-<function_name>:<opt_file_name>-<opt_phase>.suffix`.

R=ofrobots@google.com
BUG=
==========

[ofrobots, 2016-06-22 16:47:13]

ofrobots@google.com changed reviewers:
+ bmeurer@chromium.org

[mattloring, 2016-06-22 17:26:43]

Full script path is used. The trace_file_names option is now respected and the
description has been updated to be more general.

[Benedikt Meurer, 2016-06-22 17:37:44]

bmeurer@chromium.org changed reviewers:
+ danno@chromium.org

[Benedikt Meurer, 2016-06-22 17:37:44]

LGTM with nit.

https://codereview.chromium.org/2083863004/diff/20001/src/compiler/graph-visu...
File src/compiler/graph-visualizer.cc (right):

https://codereview.chromium.org/2083863004/diff/20001/src/compiler/graph-visu...
src/compiler/graph-visualizer.cc:58: SNPrintF(full_filename, "%s:%s.%s",
filename.start(), source_file, suffix);
Nit: Can we not use colon, but maybe underscore? That way it will also work on
Windows.

[mattloring, 2016-06-22 17:56:00]

The CQ bit was checked by mattloring@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-22 17:56:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2083863004/40001

[mattloring, 2016-06-22 17:56:13]

On 2016/06/22 17:37:44, Benedikt Meurer wrote:
> LGTM with nit.
> 
>
https://codereview.chromium.org/2083863004/diff/20001/src/compiler/graph-visu...
> File src/compiler/graph-visualizer.cc (right):
> 
>
https://codereview.chromium.org/2083863004/diff/20001/src/compiler/graph-visu...
> src/compiler/graph-visualizer.cc:58: SNPrintF(full_filename, "%s:%s.%s",
> filename.start(), source_file, suffix);
> Nit: Can we not use colon, but maybe underscore? That way it will also work on
> Windows.

Fixed.

[commit-bot: I haz the power, 2016-06-22 18:23:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 18:23:56]

Dry run: This issue passed the CQ dry run.

[mattloring, 2016-06-22 18:32:37]

The CQ bit was checked by mattloring@google.com

[mattloring, 2016-06-22 18:32:37]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2083863004/#ps40001
(title: "Remove : from filenames")

[commit-bot: I haz the power, 2016-06-22 18:32:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2083863004/40001

[commit-bot: I haz the power, 2016-06-22 18:35:09]

Description was changed from

==========
Include file names in trace_turbo output

The trace turbo output will overwrite itself when functions in different
files share the same name. Output files now have the form
`turbo-<function_name>:<opt_file_name>-<opt_phase>.suffix`.

R=ofrobots@google.com
BUG=
==========

to

==========
Include file names in trace_turbo output

The trace turbo output will overwrite itself when functions in different
files share the same name. Output files now have the form
`turbo-<function_name>:<opt_file_name>-<opt_phase>.suffix`.

R=ofrobots@google.com
BUG=
==========

[commit-bot: I haz the power, 2016-06-22 18:35:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-22 18:37:38]

Description was changed from

==========
Include file names in trace_turbo output

The trace turbo output will overwrite itself when functions in different
files share the same name. Output files now have the form
`turbo-<function_name>:<opt_file_name>-<opt_phase>.suffix`.

R=ofrobots@google.com
BUG=
==========

to

==========
Include file names in trace_turbo output

The trace turbo output will overwrite itself when functions in different
files share the same name. Output files now have the form
`turbo-<function_name>:<opt_file_name>-<opt_phase>.suffix`.

R=ofrobots@google.com
BUG=

Committed: https://crrev.com/a53b9bf02f31e5647c37e0392afa19f74df1a3ba
Cr-Commit-Position: refs/heads/master@{#37199}
==========

[commit-bot: I haz the power, 2016-06-22 18:37:39]

Patchset 3 (id:??) landed as
https://crrev.com/a53b9bf02f31e5647c37e0392afa19f74df1a3ba
Cr-Commit-Position: refs/heads/master@{#37199}

[mattloring, 2016-06-22 20:46:13]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2083153004/ by mattloring@google.com.

The reason for reverting is: Many build bots are failing with a message of the
form:

Missing or invalid v8 JSON file: /tmp/tmp2qcEUy_swarming/0/output.json

Can be relanded once we understand why these failures are occuring..