Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2083843002: Replace VideoStream::SizeCallback with VideoStream::Observer interface. (Closed)

Created:
4 years, 6 months ago by Sergey Ulanov
Modified:
4 years, 6 months ago
Reviewers:
Jamie
CC:
chromium-reviews, posciak+watch_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@merge-sched-stream
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace VideoStream::SizeCallback with VideoStream::Observer interface. The new Observer interface will allow to notify ClientSession when a video frame is sent, which will allow to provide the client with the frame_id->event_timestamp mapping. BUG=621691 Committed: https://crrev.com/ad51be89ed73cc6cdf56418ee9193a3a628b1f44 Cr-Commit-Position: refs/heads/master@{#401214}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -31 lines) Patch
M remoting/host/client_session.h View 3 chunks +9 lines, -2 lines 0 comments Download
M remoting/host/client_session.cc View 3 chunks +10 lines, -4 lines 0 comments Download
M remoting/host/client_session_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/protocol/fake_connection_to_client.h View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/protocol/fake_connection_to_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/protocol/video_frame_pump.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/video_frame_pump.cc View 3 chunks +10 lines, -4 lines 0 comments Download
M remoting/protocol/video_stream.h View 2 chunks +17 lines, -7 lines 0 comments Download
M remoting/protocol/webrtc_video_stream.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/webrtc_video_stream.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
Sergey Ulanov
4 years, 6 months ago (2016-06-20 22:38:22 UTC) #2
Jamie
lgtm
4 years, 6 months ago (2016-06-20 22:58:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083843002/1
4 years, 6 months ago (2016-06-22 05:21:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 06:05:02 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 06:07:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad51be89ed73cc6cdf56418ee9193a3a628b1f44
Cr-Commit-Position: refs/heads/master@{#401214}

Powered by Google App Engine
This is Rietveld 408576698