[Material][Mac] Update the incognito vector icon color to white

[Material][Mac] Update the incognito vector icon color to white

BUG=621068
Committed: https://crrev.com/0ac19cbddbeda10015a9bbdd9bce1b53715e56a0
Cr-Commit-Position: refs/heads/master@{#401477}

[spqchan, 2016-06-22 17:35:36]

spqchan@chromium.org changed reviewers:
+ shrike@chromium.org

[spqchan, 2016-06-22 17:35:36]

PTAL

[shrike, 2016-06-22 18:29:26]

Looks good, except for one more thing, which is changing the
security_state::SecurityStateModel::NONE icon color on line 735 of
location_bar_view_mac.mm to gfx::kChromeIconGrey. That's what the spec calls for
(currently it's the base text color).

[spqchan, 2016-06-22 20:34:23]

On 2016/06/22 18:29:26, shrike wrote:
> Looks good, except for one more thing, which is changing the
> security_state::SecurityStateModel::NONE icon color on line 735 of
> location_bar_view_mac.mm to gfx::kChromeIconGrey. That's what the spec calls
for
> (currently it's the base text color).

Gotcha, I changed the icon to kChromeIconGrey (and set it to white if in
incognito)
I also slightly refactored the logic.

[shrike, 2016-06-22 21:23:41]

lgtm

In location_bar_view_mac.mm where you say

  if (in_dark_mode) vector_icon_color = kMaterialDarkVectorIconColor;

would you add a comment just saying that in dark mode the color is always white?
There's a lot of logic to select a color before this spot - I just want to point
out that this if (in_dark_mode)... is intentional.

Would you also add screenshots of the icons with the cl applied (ev cert, https,
https invalid, http, in normal and Incognito modes) to the bug? For https
invalid you can use https://www.circusponies.com.

[spqchan, 2016-06-22 23:20:51]

Thanks! I'll add the screenshots to the bug.

+rsesek for OWNERS

[spqchan, 2016-06-22 23:21:05]

spqchan@chromium.org changed reviewers:
+ rsesek@chromium.org

[spqchan, 2016-06-22 23:21:06]

+rsesek for OWNERS

[Robert Sesek, 2016-06-22 23:21:59]

lgtm

[spqchan, 2016-06-22 23:24:07]

The CQ bit was checked by spqchan@chromium.org

[spqchan, 2016-06-22 23:24:07]

The patchset sent to the CQ was uploaded after l-g-t-m from shrike@chromium.org
Link to the patchset: https://codereview.chromium.org/2083813005/#ps40001
(title: "Added comment")

[commit-bot: I haz the power, 2016-06-22 23:24:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2083813005/40001

[commit-bot: I haz the power, 2016-06-23 00:16:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-23 00:20:16]

Description was changed from

==========
[Material][Mac] Update the incognito vector icon color to white

BUG=621068
==========

to

==========
[Material][Mac] Update the incognito vector icon color to white

BUG=621068

Committed: https://crrev.com/0ac19cbddbeda10015a9bbdd9bce1b53715e56a0
Cr-Commit-Position: refs/heads/master@{#401477}
==========

[commit-bot: I haz the power, 2016-06-23 00:20:17]

Patchset 3 (id:??) landed as
https://crrev.com/0ac19cbddbeda10015a9bbdd9bce1b53715e56a0
Cr-Commit-Position: refs/heads/master@{#401477}