Revert of Re-Reland: Make media/capture gn and gyps produce components (patchset #2 id:20001 of htt…

Revert of Re-Reland: Make media/capture gn and gyps produce components (patchset #2 id:20001 of https://codereview.chromium.org/2068763002/ )

Reason for revert:
Speculative revert: Appears to cause capture issues in Win7 tester using actual cameras. See below for more detail.

https://bugs.chromium.org/p/chromium/issues/detail?id=621783

Original issue's description:
> Re-Reland: Make media/capture gn and gyps produce components
>
> The CL is ready but causes a Warning C4267 (implicit size_t to int
> conversion) in some Windows Waterfall bots (not in CQ).
> After some land-archaeology, it seems that capture.gyp did not
> have the warning explicitly disable, I believe it was lost in some
> rebase. So, re-enabling it and relanding.
>
> Original re-reland description -----------------------------------------
> Re-reland: Make media/capture gn and gyps produce components
>
> Reland got reverted due to a WinX64 typical issue:
> warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
>
> This CL adds explicitly some buid/config/compiler/no_size_t_to_int_warning
> causing C4267 in
> https://build.chromium.org/p/chromium/builders/Win%20x64/builds/1472/steps/compile/logs/stdio
>
> Original reland description -------------------------------------------
> Reland: Make media/capture gn and gyps produce components
>
> Which got reverted due to a Mac build breakage (see
> https://codereview.chromium.org/2059493002/) and
> a Win one  (https://crbug.com/618854).
>
> Original description ---------------------------------------------------
> Make media/capture gn and gyps produce components
> This CL separates media/capture into a component,
> to allow, in a subsequent CL, linking with mojo for using
> ImageCapture types.
>
> This basically reproduces the media/cast and media/midi
> structure.
>
> Windows import/export issues made necessary to add
> capture_export and associated CAPTURE_EXPORT macro,
> again, replicating media/midi.
>
> gn gen ... --check uncovered some transitive dependencies
> during the "analyze" phase of the bots and I had to make
> them explicit (e.g. media:gpu).
>
> BUG=518807
> -----------------------------------------------------------------------
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
>
> TBR=avi@chromium.org, xhwang@chromium.org, miu@chromium.org
> rationale:
> reland: since the PS2/3 are trivial, just making explicit libs that are
> already elsewhere in media/ build files- I wonder why it didn't fail in
> the bots :( .
> re-reland: I'm just adding a MSVS-warning disable that was lost in a
> rebase :)
>
> Committed: https://crrev.com/a0f0c4ba5a7fd23448342a879d0a306b441af216
> Cr-Commit-Position: refs/heads/master@{#400708}

TBR=avi@chromium.org,miu@chromium.org,xhwang@chromium.org,rockot@chromium.org,mcasas@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=518807
Review-Url: https://codereview.chromium.org/2081653004
Cr-Commit-Position: refs/heads/master@{#400898}
(cherry picked from commit cc59e9ddffad4dada38daf44b7f69ac00cfbabd7)

[emircan, 2016-06-21 21:43:40]

Description was changed from

==========
Revert of Re-Reland: Make media/capture gn and gyps produce components (patchset
#2 id:20001 of https://codereview.chromium.org/2068763002/ )

Reason for revert:
Speculative revert: Appears to cause capture issues in Win7 tester using actual
cameras. See below for more detail.

https://bugs.chromium.org/p/chromium/issues/detail?id=621783

Original issue's description:
> Re-Reland: Make media/capture gn and gyps produce components
>
> The CL is ready but causes a Warning C4267 (implicit size_t to int
> conversion) in some Windows Waterfall bots (not in CQ).
> After some land-archaeology, it seems that capture.gyp did not
> have the warning explicitly disable, I believe it was lost in some
> rebase. So, re-enabling it and relanding.
>
> Original re-reland description -----------------------------------------
> Re-reland: Make media/capture gn and gyps produce components
>
> Reland got reverted due to a WinX64 typical issue:
> warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of
data
>
> This CL adds explicitly some buid/config/compiler/no_size_t_to_int_warning
> causing C4267 in
>
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/1472/steps/co...
>
> Original reland description -------------------------------------------
> Reland: Make media/capture gn and gyps produce components
>
> Which got reverted due to a Mac build breakage (see
> https://codereview.chromium.org/2059493002/) and
> a Win one  (https://crbug.com/618854).
>
> Original description ---------------------------------------------------
> Make media/capture gn and gyps produce components
> This CL separates media/capture into a component,
> to allow, in a subsequent CL, linking with mojo for using
> ImageCapture types.
>
> This basically reproduces the media/cast and media/midi
> structure.
>
> Windows import/export issues made necessary to add
> capture_export and associated CAPTURE_EXPORT macro,
> again, replicating media/midi.
>
> gn gen ... --check uncovered some transitive dependencies
> during the "analyze" phase of the bots and I had to make
> them explicit (e.g. media:gpu).
>
> BUG=518807
> -----------------------------------------------------------------------
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
>
> TBR=avi@chromium.org, xhwang@chromium.org, miu@chromium.org
> rationale:
> reland: since the PS2/3 are trivial, just making explicit libs that are
> already elsewhere in media/ build files- I wonder why it didn't fail in
> the bots :( .
> re-reland: I'm just adding a MSVS-warning disable that was lost in a
> rebase :)
>
> Committed: https://crrev.com/a0f0c4ba5a7fd23448342a879d0a306b441af216
> Cr-Commit-Position: refs/heads/master@{#400708}

TBR=avi@chromium.org,miu@chromium.org,xhwang@chromium.org,rockot@chromium.org...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=518807

Review-Url: https://codereview.chromium.org/2081653004
Cr-Commit-Position: refs/heads/master@{#400898}
(cherry picked from commit cc59e9ddffad4dada38daf44b7f69ac00cfbabd7)
==========

to

==========
Revert of Re-Reland: Make media/capture gn and gyps produce components (patchset
#2 id:20001 of https://codereview.chromium.org/2068763002/ )

Reason for revert:
Speculative revert: Appears to cause capture issues in Win7 tester using actual
cameras. See below for more detail.

https://bugs.chromium.org/p/chromium/issues/detail?id=621783

Original issue's description:
> Re-Reland: Make media/capture gn and gyps produce components
>
> The CL is ready but causes a Warning C4267 (implicit size_t to int
> conversion) in some Windows Waterfall bots (not in CQ).
> After some land-archaeology, it seems that capture.gyp did not
> have the warning explicitly disable, I believe it was lost in some
> rebase. So, re-enabling it and relanding.
>
> Original re-reland description -----------------------------------------
> Re-reland: Make media/capture gn and gyps produce components
>
> Reland got reverted due to a WinX64 typical issue:
> warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of
data
>
> This CL adds explicitly some buid/config/compiler/no_size_t_to_int_warning
> causing C4267 in
>
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/1472/steps/co...
>
> Original reland description -------------------------------------------
> Reland: Make media/capture gn and gyps produce components
>
> Which got reverted due to a Mac build breakage (see
> https://codereview.chromium.org/2059493002/) and
> a Win one  (https://crbug.com/618854).
>
> Original description ---------------------------------------------------
> Make media/capture gn and gyps produce components
> This CL separates media/capture into a component,
> to allow, in a subsequent CL, linking with mojo for using
> ImageCapture types.
>
> This basically reproduces the media/cast and media/midi
> structure.
>
> Windows import/export issues made necessary to add
> capture_export and associated CAPTURE_EXPORT macro,
> again, replicating media/midi.
>
> gn gen ... --check uncovered some transitive dependencies
> during the "analyze" phase of the bots and I had to make
> them explicit (e.g. media:gpu).
>
> BUG=518807
> -----------------------------------------------------------------------
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
>
> TBR=avi@chromium.org, xhwang@chromium.org, miu@chromium.org
> rationale:
> reland: since the PS2/3 are trivial, just making explicit libs that are
> already elsewhere in media/ build files- I wonder why it didn't fail in
> the bots :( .
> re-reland: I'm just adding a MSVS-warning disable that was lost in a
> rebase :)
>
> Committed: https://crrev.com/a0f0c4ba5a7fd23448342a879d0a306b441af216
> Cr-Commit-Position: refs/heads/master@{#400708}

TBR=avi@chromium.org,miu@chromium.org,xhwang@chromium.org,rockot@chromium.org...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=518807

Review-Url: https://codereview.chromium.org/2081653004
Cr-Commit-Position: refs/heads/master@{#400898}
(cherry picked from commit cc59e9ddffad4dada38daf44b7f69ac00cfbabd7)
==========

[emircan, 2016-06-21 21:43:41]

emircan@chromium.org changed reviewers:
- avi@chromium.org, mcasas@chromium.org, miu@chromium.org, rockot@chromium.org,
xhwang@chromium.org

[emircan, 2016-06-21 21:44:48]

The CQ bit was checked by emircan@chromium.org

[commit-bot: I haz the power, 2016-06-21 21:45:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2083813003/1

[commit-bot: I haz the power, 2016-06-21 21:49:06]

Description was changed from

==========
Revert of Re-Reland: Make media/capture gn and gyps produce components (patchset
#2 id:20001 of https://codereview.chromium.org/2068763002/ )

Reason for revert:
Speculative revert: Appears to cause capture issues in Win7 tester using actual
cameras. See below for more detail.

https://bugs.chromium.org/p/chromium/issues/detail?id=621783

Original issue's description:
> Re-Reland: Make media/capture gn and gyps produce components
>
> The CL is ready but causes a Warning C4267 (implicit size_t to int
> conversion) in some Windows Waterfall bots (not in CQ).
> After some land-archaeology, it seems that capture.gyp did not
> have the warning explicitly disable, I believe it was lost in some
> rebase. So, re-enabling it and relanding.
>
> Original re-reland description -----------------------------------------
> Re-reland: Make media/capture gn and gyps produce components
>
> Reland got reverted due to a WinX64 typical issue:
> warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of
data
>
> This CL adds explicitly some buid/config/compiler/no_size_t_to_int_warning
> causing C4267 in
>
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/1472/steps/co...
>
> Original reland description -------------------------------------------
> Reland: Make media/capture gn and gyps produce components
>
> Which got reverted due to a Mac build breakage (see
> https://codereview.chromium.org/2059493002/) and
> a Win one  (https://crbug.com/618854).
>
> Original description ---------------------------------------------------
> Make media/capture gn and gyps produce components
> This CL separates media/capture into a component,
> to allow, in a subsequent CL, linking with mojo for using
> ImageCapture types.
>
> This basically reproduces the media/cast and media/midi
> structure.
>
> Windows import/export issues made necessary to add
> capture_export and associated CAPTURE_EXPORT macro,
> again, replicating media/midi.
>
> gn gen ... --check uncovered some transitive dependencies
> during the "analyze" phase of the bots and I had to make
> them explicit (e.g. media:gpu).
>
> BUG=518807
> -----------------------------------------------------------------------
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
>
> TBR=avi@chromium.org, xhwang@chromium.org, miu@chromium.org
> rationale:
> reland: since the PS2/3 are trivial, just making explicit libs that are
> already elsewhere in media/ build files- I wonder why it didn't fail in
> the bots :( .
> re-reland: I'm just adding a MSVS-warning disable that was lost in a
> rebase :)
>
> Committed: https://crrev.com/a0f0c4ba5a7fd23448342a879d0a306b441af216
> Cr-Commit-Position: refs/heads/master@{#400708}

TBR=avi@chromium.org,miu@chromium.org,xhwang@chromium.org,rockot@chromium.org...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=518807

Review-Url: https://codereview.chromium.org/2081653004
Cr-Commit-Position: refs/heads/master@{#400898}
(cherry picked from commit cc59e9ddffad4dada38daf44b7f69ac00cfbabd7)
==========

to

==========
Revert of Re-Reland: Make media/capture gn and gyps produce components (patchset
#2 id:20001 of https://codereview.chromium.org/2068763002/ )

Reason for revert:
Speculative revert: Appears to cause capture issues in Win7 tester using actual
cameras. See below for more detail.

https://bugs.chromium.org/p/chromium/issues/detail?id=621783

Original issue's description:
> Re-Reland: Make media/capture gn and gyps produce components
>
> The CL is ready but causes a Warning C4267 (implicit size_t to int
> conversion) in some Windows Waterfall bots (not in CQ).
> After some land-archaeology, it seems that capture.gyp did not
> have the warning explicitly disable, I believe it was lost in some
> rebase. So, re-enabling it and relanding.
>
> Original re-reland description -----------------------------------------
> Re-reland: Make media/capture gn and gyps produce components
>
> Reland got reverted due to a WinX64 typical issue:
> warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of
data
>
> This CL adds explicitly some buid/config/compiler/no_size_t_to_int_warning
> causing C4267 in
>
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/1472/steps/co...
>
> Original reland description -------------------------------------------
> Reland: Make media/capture gn and gyps produce components
>
> Which got reverted due to a Mac build breakage (see
> https://codereview.chromium.org/2059493002/) and
> a Win one  (https://crbug.com/618854).
>
> Original description ---------------------------------------------------
> Make media/capture gn and gyps produce components
> This CL separates media/capture into a component,
> to allow, in a subsequent CL, linking with mojo for using
> ImageCapture types.
>
> This basically reproduces the media/cast and media/midi
> structure.
>
> Windows import/export issues made necessary to add
> capture_export and associated CAPTURE_EXPORT macro,
> again, replicating media/midi.
>
> gn gen ... --check uncovered some transitive dependencies
> during the "analyze" phase of the bots and I had to make
> them explicit (e.g. media:gpu).
>
> BUG=518807
> -----------------------------------------------------------------------
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
>
> TBR=avi@chromium.org, xhwang@chromium.org, miu@chromium.org
> rationale:
> reland: since the PS2/3 are trivial, just making explicit libs that are
> already elsewhere in media/ build files- I wonder why it didn't fail in
> the bots :( .
> re-reland: I'm just adding a MSVS-warning disable that was lost in a
> rebase :)
>
> Committed: https://crrev.com/a0f0c4ba5a7fd23448342a879d0a306b441af216
> Cr-Commit-Position: refs/heads/master@{#400708}

TBR=avi@chromium.org,miu@chromium.org,xhwang@chromium.org,rockot@chromium.org...
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=518807

Review-Url: https://codereview.chromium.org/2081653004
Cr-Commit-Position: refs/heads/master@{#400898}
(cherry picked from commit cc59e9ddffad4dada38daf44b7f69ac00cfbabd7)
==========

[commit-bot: I haz the power, 2016-06-21 21:49:09]

Committed patchset #1 (id:1)