Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 2083783002: [Offline pages] Renaming the file with request queue store tests (Closed)

Created:
4 years, 6 months ago by fgorski
Modified:
4 years, 6 months ago
Reviewers:
romax
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Renaming the file with request queue store tests This patch moves out file renaming from issue 2053163002 BUG=607221 Committed: https://crrev.com/c2c55ab11fee910d1426e0b59de55a88c5f36420 Cr-Commit-Position: refs/heads/master@{#400810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -254 lines) Patch
M components/components_tests.gyp View 9 chunks +9 lines, -9 lines 0 comments Download
M components/offline_pages/background/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D components/offline_pages/background/request_queue_in_memory_store_unittest.cc View 1 chunk +0 lines, -242 lines 0 comments Download
A + components/offline_pages/background/request_queue_store_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fgorski
PTAL
4 years, 6 months ago (2016-06-20 21:13:05 UTC) #2
romax
lgtm
4 years, 6 months ago (2016-06-20 21:37:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083783002/1
4 years, 6 months ago (2016-06-20 21:38:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 22:16:12 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 22:30:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2c55ab11fee910d1426e0b59de55a88c5f36420
Cr-Commit-Position: refs/heads/master@{#400810}

Powered by Google App Engine
This is Rietveld 408576698