Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Issue 2083713002: Remove calls to MessageLoop::current() in sync. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
Reviewers:
maxbogue
CC:
chromium-reviews, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to MessageLoop::current() in sync. Why? The fact that there's a MessageLoop on the thread is an unnecessary implementation detail. When browser threads are migrated to base/task_scheduler, tasks will no longer have access to a MessageLoop. These changes were generated manually. BUG=616447 R=maxbogue@chromium.org Committed: https://crrev.com/f7ca8b710dcd9f45e852ceea546b5de96e8d7ca3 Cr-Commit-Position: refs/heads/master@{#400983}

Patch Set 1 #

Patch Set 2 : self-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -39 lines) Patch
M sync/internal_api/http_bridge.cc View 7 chunks +7 lines, -10 lines 0 comments Download
M sync/internal_api/http_bridge_unittest.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M sync/internal_api/public/engine/model_safe_worker.h View 2 chunks +4 lines, -3 lines 0 comments Download
M sync/internal_api/public/engine/model_safe_worker.cc View 1 6 chunks +15 lines, -16 lines 0 comments Download
M sync/internal_api/public/http_bridge.h View 1 3 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
maxbogue
lgtm
4 years, 6 months ago (2016-06-21 02:40:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083713002/20001
4 years, 6 months ago (2016-06-21 12:59:38 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-21 14:00:45 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 14:02:31 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f7ca8b710dcd9f45e852ceea546b5de96e8d7ca3
Cr-Commit-Position: refs/heads/master@{#400983}

Powered by Google App Engine
This is Rietveld 408576698