Site Settings Desktop: Add Closure coverage for two modules.

Site Settings Desktop: Add Closure coverage for two modules.

BUG=543635
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4e2a19affa8bedecca8965804e9e9d137709d04d
Cr-Commit-Position: refs/heads/master@{#403457}

[Finnur, 2016-06-21 10:36:45]

Description was changed from

==========
Site Settings Desktop: Add Closure coverage for two modules.

BUG=543635
==========

to

==========
Site Settings Desktop: Add Closure coverage for two modules.

BUG=543635
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Finnur, 2016-06-21 10:37:27]

finnur@chromium.org changed reviewers:
+ tommycli@chromium.org

[tommycli, 2016-06-21 15:47:26]

lgtm sans below

https://codereview.chromium.org/2083703003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/site_settings/compiled_resources2.gyp
(right):

https://codereview.chromium.org/2083703003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings/compiled_resources2.gyp:10:
'site_settings_prefs_browser_proxy',
It seems that the site_settings_prefs_browser_proxy should be a transitive
dependency of site_settings_behavior, since that's where it's declared.

Then maybe you could remove it from other places that depend on
site_settings_behavior?

Worth a shot.

[Finnur, 2016-07-01 14:49:20]

https://codereview.chromium.org/2083703003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/site_settings/compiled_resources2.gyp
(right):

https://codereview.chromium.org/2083703003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings/compiled_resources2.gyp:10:
'site_settings_prefs_browser_proxy',
Good idea. Done. Checking in.

[Finnur, 2016-07-01 14:49:23]

The CQ bit was checked by finnur@chromium.org

[Finnur, 2016-07-01 14:49:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2083703003/#ps20001
(title: "Address feedback")

[commit-bot: I haz the power, 2016-07-01 14:49:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 15:25:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-01 15:25:42]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-01 15:27:18]

Description was changed from

==========
Site Settings Desktop: Add Closure coverage for two modules.

BUG=543635
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Site Settings Desktop: Add Closure coverage for two modules.

BUG=543635
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4e2a19affa8bedecca8965804e9e9d137709d04d
Cr-Commit-Position: refs/heads/master@{#403457}
==========

[commit-bot: I haz the power, 2016-07-01 15:27:19]

Patchset 2 (id:??) landed as
https://crrev.com/4e2a19affa8bedecca8965804e9e9d137709d04d
Cr-Commit-Position: refs/heads/master@{#403457}