Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issue 2083703003: Site Settings Desktop: Add Closure coverage for two modules. (Closed)

Created:
4 years, 6 months ago by Finnur
Modified:
4 years, 5 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Site Settings Desktop: Add Closure coverage for two modules. BUG=543635 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/4e2a19affa8bedecca8965804e9e9d137709d04d Cr-Commit-Position: refs/heads/master@{#403457}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M chrome/browser/resources/settings/site_settings/compiled_resources2.gyp View 1 7 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Finnur
4 years, 6 months ago (2016-06-21 10:37:28 UTC) #3
tommycli
lgtm sans below https://codereview.chromium.org/2083703003/diff/1/chrome/browser/resources/settings/site_settings/compiled_resources2.gyp File chrome/browser/resources/settings/site_settings/compiled_resources2.gyp (right): https://codereview.chromium.org/2083703003/diff/1/chrome/browser/resources/settings/site_settings/compiled_resources2.gyp#newcode10 chrome/browser/resources/settings/site_settings/compiled_resources2.gyp:10: 'site_settings_prefs_browser_proxy', It seems that the site_settings_prefs_browser_proxy ...
4 years, 6 months ago (2016-06-21 15:47:26 UTC) #4
Finnur
https://codereview.chromium.org/2083703003/diff/1/chrome/browser/resources/settings/site_settings/compiled_resources2.gyp File chrome/browser/resources/settings/site_settings/compiled_resources2.gyp (right): https://codereview.chromium.org/2083703003/diff/1/chrome/browser/resources/settings/site_settings/compiled_resources2.gyp#newcode10 chrome/browser/resources/settings/site_settings/compiled_resources2.gyp:10: 'site_settings_prefs_browser_proxy', Good idea. Done. Checking in.
4 years, 5 months ago (2016-07-01 14:49:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2083703003/20001
4 years, 5 months ago (2016-07-01 14:49:31 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-01 15:25:36 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 15:25:42 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 15:27:19 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4e2a19affa8bedecca8965804e9e9d137709d04d
Cr-Commit-Position: refs/heads/master@{#403457}

Powered by Google App Engine
This is Rietveld 408576698