components/offline_pages/offline_page_model_impl.cc - Issue 2083653008: Temporarily remove "last_n" from availability searches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/offline_page_model_impl.cc

Issue 2083653008: Temporarily remove "last_n" from availability searches. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/recent_tab_helper.cc ('k') | components/offline_pages/offline_page_model_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/offline_page_model_impl.cc

diff --git a/components/offline_pages/offline_page_model_impl.cc b/components/offline_pages/offline_page_model_impl.cc

index 4d6f1d7af3939455a3ab139c1001cfda815afc1a..8b7513813bdefb3d364172d6d859e07a2abb783e 100644

--- a/components/offline_pages/offline_page_model_impl.cc

+++ b/components/offline_pages/offline_page_model_impl.cc

@@ -18,6 +18,7 @@

#include "base/threading/thread_task_runner_handle.h"

#include "base/time/time.h"

#include "components/offline_pages/archive_manager.h"

+#include "components/offline_pages/client_namespace_constants.h"

#include "components/offline_pages/client_policy_controller.h"

#include "components/offline_pages/offline_page_item.h"

#include "components/offline_pages/offline_page_storage_manager.h"

@@ -437,7 +438,10 @@ void OfflinePageModelImpl::CheckPagesExistOfflineAfterLoadDone(

DCHECK(is_loaded_);

CheckPagesExistOfflineResult result;

for (const auto& id_page_pair : offline_pages_) {

- if (id_page_pair.second.IsExpired())

+ // TODO(dewittj): Remove the "Last N" restriction in favor of a better query

+ // interface. See https://crbug.com/622424 for information.

Dmitry Titov 2016/06/23 16:24:27 Lets create a new bug to specifically remove this

dewittj 2016/06/23 16:39:36 Done.

+ if (id_page_pair.second.IsExpired() ||

+ id_page_pair.second.client_id.name_space == kLastNNamespace)

continue;

auto iter = urls.find(id_page_pair.second.url);

if (iter != urls.end())