Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2083653008: Temporarily remove "last_n" from availability searches. (Closed)

Created:
4 years, 6 months ago by dewittj
Modified:
4 years, 6 months ago
Reviewers:
Dmitry Titov
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily remove "last_n" from availability searches. This is a part of the Last N==1 feature, which associates a single offline page with a particular tab. BUG=622424 Committed: https://crrev.com/1a57193f0add291fb6d5e6c9072a718c49db4c80 Cr-Commit-Position: refs/heads/master@{#401643}

Patch Set 1 #

Total comments: 2

Patch Set 2 : gNit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M chrome/browser/android/offline_pages/recent_tab_helper.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M components/offline_pages/offline_page_model_impl.cc View 1 2 chunks +5 lines, -1 line 0 comments Download
M components/offline_pages/offline_page_model_impl_unittest.cc View 1 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
dewittj
dimich: PTAL, thanks.
4 years, 6 months ago (2016-06-22 19:26:02 UTC) #3
dewittj
friendly ping
4 years, 6 months ago (2016-06-23 16:11:42 UTC) #4
Dmitry Titov
lgtm with this: https://codereview.chromium.org/2083653008/diff/1/components/offline_pages/offline_page_model_impl.cc File components/offline_pages/offline_page_model_impl.cc (right): https://codereview.chromium.org/2083653008/diff/1/components/offline_pages/offline_page_model_impl.cc#newcode442 components/offline_pages/offline_page_model_impl.cc:442: // interface. See https://crbug.com/622424 for information. ...
4 years, 6 months ago (2016-06-23 16:24:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083653008/20001
4 years, 6 months ago (2016-06-23 16:38:13 UTC) #8
dewittj
https://codereview.chromium.org/2083653008/diff/1/components/offline_pages/offline_page_model_impl.cc File components/offline_pages/offline_page_model_impl.cc (right): https://codereview.chromium.org/2083653008/diff/1/components/offline_pages/offline_page_model_impl.cc#newcode442 components/offline_pages/offline_page_model_impl.cc:442: // interface. See https://crbug.com/622424 for information. On 2016/06/23 16:24:27, ...
4 years, 6 months ago (2016-06-23 16:39:36 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-23 17:26:35 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 17:42:05 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1a57193f0add291fb6d5e6c9072a718c49db4c80
Cr-Commit-Position: refs/heads/master@{#401643}

Powered by Google App Engine
This is Rietveld 408576698