Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2083633002: AudioOutputDevice authorization timeout decreased (Closed)

Created:
4 years, 6 months ago by o1ka
Modified:
4 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

AudioOutputDevice authorization timeout decreased BUG=615589 Committed: https://crrev.com/70d5e74e6225e01dc2ade9b89a7c30f5bdb356e1 Cr-Commit-Position: refs/heads/master@{#402467}

Patch Set 1 : timeout #

Patch Set 2 : Changed timeout to 900 ms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/media/audio_device_factory.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
o1ka
PTAL
4 years, 6 months ago (2016-06-20 15:42:51 UTC) #4
o1ka
On 2016/06/20 15:42:51, o1ka wrote: > PTAL Actually, probably we don't need this, taking into ...
4 years, 6 months ago (2016-06-20 17:32:52 UTC) #5
DaleCurtis
Okay will hold off, I think the other one was more beneficial for http://crbug.com/422522, we ...
4 years, 6 months ago (2016-06-20 17:41:57 UTC) #6
o1ka
tommi@, could you approve this CL to make things faster? the approach is discussed with ...
4 years, 5 months ago (2016-06-28 13:38:46 UTC) #8
tommi (sloooow) - chröme
lgtm
4 years, 5 months ago (2016-06-28 13:49:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2083633002/40001
4 years, 5 months ago (2016-06-28 14:00:30 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 5 months ago (2016-06-28 14:53:16 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/70d5e74e6225e01dc2ade9b89a7c30f5bdb356e1 Cr-Commit-Position: refs/heads/master@{#402467}
4 years, 5 months ago (2016-06-28 14:54:44 UTC) #15
o1ka
4 years, 5 months ago (2016-06-30 09:30:40 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/2106373002/ by olka@chromium.org.

The reason for reverting is: Needs to be restricted to windows-only.

Powered by Google App Engine
This is Rietveld 408576698