Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: test/cctest/test-serialize.cc

Issue 2083573002: [builtins] Unify Cosh, Sinh and Tanh as exports from flibm (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE and windows fix. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/compiler/test-run-machops.cc ('k') | test/unittests/base/ieee754-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-serialize.cc
diff --git a/test/cctest/test-serialize.cc b/test/cctest/test-serialize.cc
index 2fed210d153c759b938c7d5121284e0a0c545ff9..9fc9e1c46a2c311ded7d67c37326904c6bf63048 100644
--- a/test/cctest/test-serialize.cc
+++ b/test/cctest/test-serialize.cc
@@ -791,7 +791,7 @@ bool IsCompiled(const char* name) {
TEST(SnapshotDataBlobWithWarmup) {
DisableTurbofan();
- const char* warmup = "Math.tanh(1); Math.sinh = 1;";
+ const char* warmup = "Math.abs(1); Math.random = 1;";
v8::StartupData cold = v8::V8::CreateSnapshotDataBlob();
v8::StartupData warm = v8::V8::WarmUpSnapshotDataBlob(cold, warmup);
@@ -810,9 +810,9 @@ TEST(SnapshotDataBlobWithWarmup) {
v8::Context::Scope c_scope(context);
// Running the warmup script has effect on whether functions are
// pre-compiled, but does not pollute the context.
- CHECK(IsCompiled("Math.tanh"));
- CHECK(!IsCompiled("Math.cosh"));
- CHECK(CompileRun("Math.sinh")->IsFunction());
+ CHECK(IsCompiled("Math.abs"));
+ CHECK(!IsCompiled("Math.sign"));
+ CHECK(CompileRun("Math.random")->IsFunction());
}
isolate->Dispose();
}
@@ -820,9 +820,9 @@ TEST(SnapshotDataBlobWithWarmup) {
TEST(CustomSnapshotDataBlobWithWarmup) {
DisableTurbofan();
const char* source =
- "function f() { return Math.sinh(1); }\n"
- "function g() { return Math.cosh(1); }\n"
- "Math.tanh(1);"
+ "function f() { return Math.abs(1); }\n"
+ "function g() { return Math.sign(1); }\n"
+ "Math.asinh(1);"
"var a = 5";
const char* warmup = "a = f()";
@@ -844,10 +844,10 @@ TEST(CustomSnapshotDataBlobWithWarmup) {
// Running the warmup script has effect on whether functions are
// pre-compiled, but does not pollute the context.
CHECK(IsCompiled("f"));
- CHECK(IsCompiled("Math.sinh"));
+ CHECK(IsCompiled("Math.abs"));
CHECK(!IsCompiled("g"));
- CHECK(!IsCompiled("Math.cosh"));
- CHECK(!IsCompiled("Math.tanh"));
+ CHECK(!IsCompiled("Math.sign"));
+ CHECK(!IsCompiled("Math.asinh"));
CHECK_EQ(5, CompileRun("a")->Int32Value(context).FromJust());
}
isolate->Dispose();
« no previous file with comments | « test/cctest/compiler/test-run-machops.cc ('k') | test/unittests/base/ieee754-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698