Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2083523004: PPC/s390: [builtins] Use BUILTIN frame in DatePrototype_GetField (Closed)

Created:
4 years, 6 months ago by JaideepBajwa
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [builtins] Use BUILTIN frame in DatePrototype_GetField Port 198e09de5a72eb734918bdf3943f37202fdc644d Original commit message: Construct a BUILTIN frame before throwing an exception from runtime. R=jgruber@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= Committed: https://crrev.com/c0630818b7710635b8fdf4e2cc4540f9c612f7a4 Cr-Commit-Position: refs/heads/master@{#37118}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M src/ppc/builtins-ppc.cc View 3 chunks +12 lines, -2 lines 0 comments Download
M src/s390/builtins-s390.cc View 3 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
john.yan
lgtm
4 years, 6 months ago (2016-06-20 23:10:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083523004/1
4 years, 6 months ago (2016-06-20 23:15:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 23:38:38 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 23:39:28 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0630818b7710635b8fdf4e2cc4540f9c612f7a4
Cr-Commit-Position: refs/heads/master@{#37118}

Powered by Google App Engine
This is Rietveld 408576698