Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Issue 2083493004: Remove calls to MessageLoop::current() in chromeos. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 5 months ago
Reviewers:
armansito, oshima, zel
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to MessageLoop::current() in chromeos. Why? The fact that there's a MessageLoop on the thread is an unnecessary implementation detail. When browser threads are migrated to base/task_scheduler, tasks will no longer have access to a MessageLoop. These changes were generated manually. BUG=616447 R=zelidrag@chromium.org Committed: https://crrev.com/42eea45c7d8947db18f7672b1f07f7ae25d4e977 Cr-Commit-Position: refs/heads/master@{#403172}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chromeos/network/managed_network_configuration_handler_impl.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-21 17:24:58 UTC) #1
fdoray
+oshima@chromium.org: Can you review this CL? Thanks.
4 years, 5 months ago (2016-06-28 21:05:05 UTC) #3
oshima
lgtm
4 years, 5 months ago (2016-06-28 22:46:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2083493004/1
4 years, 5 months ago (2016-06-29 12:32:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/209360)
4 years, 5 months ago (2016-06-29 12:39:22 UTC) #8
fdoray
+armansito@chromium.org: Can you review this CL? Thanks.
4 years, 5 months ago (2016-06-29 13:22:11 UTC) #10
armansito
lgtm
4 years, 5 months ago (2016-06-30 02:54:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2083493004/1
4 years, 5 months ago (2016-06-30 13:28:46 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 14:38:59 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 14:42:01 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42eea45c7d8947db18f7672b1f07f7ae25d4e977
Cr-Commit-Position: refs/heads/master@{#403172}

Powered by Google App Engine
This is Rietveld 408576698