Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2083473002: [wasm] Use the new TF operators for F64Cos, F64Sin, F64Tan, and F64Exp (Closed)

Created:
4 years, 6 months ago by ahaas
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Use the new TF operators for F64Cos, F64Sin, F64Tan, and F64Exp R=bmeurer@chromium.org, bradnelson@chromium.org BUG=v8:5086 Committed: https://crrev.com/cdf4d10d131532e273a3750b92a45f259450e2d7 Cr-Commit-Position: refs/heads/master@{#37094}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -84 lines) Patch
M src/assembler.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/assembler.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M src/compiler/wasm-compiler.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 2 chunks +8 lines, -32 lines 0 comments Download
M src/external-reference-table.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ahaas
4 years, 6 months ago (2016-06-20 08:58:52 UTC) #1
Benedikt Meurer
Nice. LGTM!
4 years, 6 months ago (2016-06-20 08:59:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083473002/1
4 years, 6 months ago (2016-06-20 09:00:15 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 09:28:44 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cdf4d10d131532e273a3750b92a45f259450e2d7 Cr-Commit-Position: refs/heads/master@{#37094}
4 years, 6 months ago (2016-06-20 09:29:22 UTC) #7
bradn
4 years, 6 months ago (2016-06-20 16:50:05 UTC) #9
Message was sent while issue was closed.
Nice indeed.
Is the plan that others like Atan will become operators as well eventually?

Powered by Google App Engine
This is Rietveld 408576698