Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3420)

Unified Diff: base/trace_event/winheap_dump_provider_win.cc

Issue 2083463003: Revert of Add chrome_crash_reporter_client_win.cc to the source file list for chrome_elf (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/threading/platform_thread_win.cc ('k') | chrome/app/chrome_crash_reporter_client_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/winheap_dump_provider_win.cc
diff --git a/base/trace_event/winheap_dump_provider_win.cc b/base/trace_event/winheap_dump_provider_win.cc
index f918aafad196fce937b98d1f199e5fe00c19d0cb..80956369cca218a4247a1e36fe873ca9da963670 100644
--- a/base/trace_event/winheap_dump_provider_win.cc
+++ b/base/trace_event/winheap_dump_provider_win.cc
@@ -9,6 +9,7 @@
#include "base/debug/profiler.h"
#include "base/strings/string_util.h"
#include "base/trace_event/process_memory_dump.h"
+#include "base/win/windows_version.h"
namespace base {
namespace trace_event {
@@ -55,7 +56,13 @@
// then chaos should be assumed. This flakyness is acceptable for tracing.
// - The MSDN page for HeapLock says: "If the HeapLock function is called on
// a heap created with the HEAP_NO_SERIALIZATION flag, the results are
- // undefined."
+ // undefined.". This is a problem on Windows XP where some system DLLs are
+ // known for creating heaps with this particular flag. For this reason
+ // this function should be disabled on XP.
+ //
+ // See https://crbug.com/487291 for more details about this.
+ if (base::win::GetVersion() < base::win::VERSION_VISTA)
+ return false;
// Disable this dump provider for the SyzyASan instrumented build
// because they don't support the heap walking functions yet.
« no previous file with comments | « base/threading/platform_thread_win.cc ('k') | chrome/app/chrome_crash_reporter_client_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698