Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2083453003: Split the XFA_OBJECTTYPE enum into two parts. (Closed)

Created:
4 years, 6 months ago by dsinclair
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Split the XFA_OBJECTTYPE enum into two parts. Currently the object type and the node flags are both mixed into the single XFA_OBJECTTYPE_* enum. These two things are un-related and should not share a single type. This Cl creates an XFA_ObjectType enum class and a XFA_NodeFlag enum to hold the two types. Accessors are added to determine if the flags are set (or called where they already existed. Committed: https://pdfium.googlesource.com/pdfium/+/c5a8f217fedc1224104b34f7577044776a9d83d8

Patch Set 1 #

Patch Set 2 : Cleanup HasFlag #

Patch Set 3 : Force to bool #

Total comments: 4

Patch Set 4 : Use HasFlag #

Patch Set 5 : Fix == nullptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+615 lines, -608 lines) Patch
M xfa/fxfa/app/xfa_ffdocview.cpp View 6 chunks +10 lines, -10 lines 0 comments Download
M xfa/fxfa/app/xfa_fffield.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_ffnotify.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffwidgetacc.cpp View 11 chunks +20 lines, -23 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidgethandler.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/include/fxfa_basic.h View 2 chunks +2 lines, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_widgetdata.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_basic_data.cpp View 1 chunk +322 lines, -312 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_datadescription_imp.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_datamerger_imp.cpp View 18 chunks +30 lines, -40 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_imp.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_layout_imp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document_serialize.cpp View 5 chunks +14 lines, -16 lines 0 comments Download
M xfa/fxfa/parser/xfa_layout_itemlayout.cpp View 1 2 3 4 5 chunks +13 lines, -15 lines 0 comments Download
M xfa/fxfa/parser/xfa_layout_pagemgr_new.cpp View 19 chunks +28 lines, -29 lines 0 comments Download
M xfa/fxfa/parser/xfa_object.h View 1 2 3 7 chunks +73 lines, -44 lines 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 1 42 chunks +68 lines, -82 lines 0 comments Download
M xfa/fxfa/parser/xfa_parser_imp.cpp View 12 chunks +15 lines, -15 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.cpp View 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
dsinclair
PTAL.
4 years, 6 months ago (2016-06-20 16:11:40 UTC) #2
Lei Zhang
Still got red Windows bots.
4 years, 6 months ago (2016-06-20 16:15:00 UTC) #3
dsinclair
On 2016/06/20 16:15:00, Lei Zhang wrote: > Still got red Windows bots. All green.
4 years, 6 months ago (2016-06-20 17:11:36 UTC) #4
Lei Zhang
https://codereview.chromium.org/2083453003/diff/40001/xfa/fxfa/parser/xfa_object.h File xfa/fxfa/parser/xfa_object.h (right): https://codereview.chromium.org/2083453003/diff/40001/xfa/fxfa/parser/xfa_object.h#newcode169 xfa/fxfa/parser/xfa_object.h:169: return !!(m_uNodeFlags & XFA_NodeFlag_BindFormItems); Why can't this just call ...
4 years, 6 months ago (2016-06-20 17:24:06 UTC) #5
dsinclair
https://codereview.chromium.org/2083453003/diff/40001/xfa/fxfa/parser/xfa_object.h File xfa/fxfa/parser/xfa_object.h (right): https://codereview.chromium.org/2083453003/diff/40001/xfa/fxfa/parser/xfa_object.h#newcode169 xfa/fxfa/parser/xfa_object.h:169: return !!(m_uNodeFlags & XFA_NodeFlag_BindFormItems); On 2016/06/20 17:24:06, Lei Zhang ...
4 years, 6 months ago (2016-06-20 17:28:40 UTC) #6
Lei Zhang
lgtm https://codereview.chromium.org/2083453003/diff/40001/xfa/fxfa/parser/xfa_layout_itemlayout.cpp File xfa/fxfa/parser/xfa_layout_itemlayout.cpp (right): https://codereview.chromium.org/2083453003/diff/40001/xfa/fxfa/parser/xfa_layout_itemlayout.cpp#newcode2171 xfa/fxfa/parser/xfa_layout_itemlayout.cpp:2171: if (firstChild && firstChild->m_pNextSibling == nullptr && foo ...
4 years, 6 months ago (2016-06-20 17:32:19 UTC) #7
dsinclair
https://codereview.chromium.org/2083453003/diff/40001/xfa/fxfa/parser/xfa_layout_itemlayout.cpp File xfa/fxfa/parser/xfa_layout_itemlayout.cpp (right): https://codereview.chromium.org/2083453003/diff/40001/xfa/fxfa/parser/xfa_layout_itemlayout.cpp#newcode2171 xfa/fxfa/parser/xfa_layout_itemlayout.cpp:2171: if (firstChild && firstChild->m_pNextSibling == nullptr && On 2016/06/20 ...
4 years, 6 months ago (2016-06-20 17:38:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083453003/80001
4 years, 6 months ago (2016-06-20 17:39:12 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 18:11:20 UTC) #13
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/c5a8f217fedc1224104b34f7577044776a9d...

Powered by Google App Engine
This is Rietveld 408576698