Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Unified Diff: cc/trees/proxy_impl.cc

Issue 2083423006: Remove default begin frame sources from the renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: danakj comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/proxy_impl.cc
diff --git a/cc/trees/proxy_impl.cc b/cc/trees/proxy_impl.cc
index 7defc51fd4b093d6b995c1b282d38af7ea943d12..4bc28c84a1f11825b88a8d369687fe39098c8b8c 100644
--- a/cc/trees/proxy_impl.cc
+++ b/cc/trees/proxy_impl.cc
@@ -77,24 +77,20 @@ ProxyImpl::ProxyImpl(
CompositorTimingHistory::RENDERER_UMA,
rendering_stats_instrumentation_));
- BeginFrameSource* frame_source = external_begin_frame_source_.get();
- if (!scheduler_settings.throttle_frame_production) {
- // Unthrottled source takes precedence over external sources.
- unthrottled_begin_frame_source_.reset(
- new BackToBackBeginFrameSource(base::MakeUnique<DelayBasedTimeSource>(
- task_runner_provider_->ImplThreadTaskRunner())));
- frame_source = unthrottled_begin_frame_source_.get();
- }
- if (!frame_source) {
- synthetic_begin_frame_source_.reset(
- new DelayBasedBeginFrameSource(base::MakeUnique<DelayBasedTimeSource>(
- task_runner_provider_->ImplThreadTaskRunner())));
- frame_source = synthetic_begin_frame_source_.get();
- }
- scheduler_ =
- Scheduler::Create(this, scheduler_settings, layer_tree_host_id_,
- task_runner_provider_->ImplThreadTaskRunner(),
- frame_source, std::move(compositor_timing_history));
+ // BFS must either be external or come from the output surface. If
+ // external, it must be provided. If from the output surface, it must
+ // not be provided.
+ // TODO(enne): Make all BFS come from the output surface.
+ DCHECK(layer_tree_host->settings().use_external_begin_frame_source ^
+ layer_tree_host->settings().use_output_surface_begin_frame_source);
+ DCHECK(!layer_tree_host->settings().use_external_begin_frame_source ||
+ external_begin_frame_source_);
+ DCHECK(!layer_tree_host->settings().use_output_surface_begin_frame_source ||
+ !external_begin_frame_source_);
+ scheduler_ = Scheduler::Create(this, scheduler_settings, layer_tree_host_id_,
+ task_runner_provider_->ImplThreadTaskRunner(),
+ external_begin_frame_source_.get(),
+ std::move(compositor_timing_history));
DCHECK_EQ(scheduler_->visible(), layer_tree_host_impl_->visible());
}

Powered by Google App Engine
This is Rietveld 408576698