arc/bluetooth: plumb adapter discoverable timeout property

arc/bluetooth: plumb adapter discoverable timeout property

Instead of hardcoding this to 120, we'll pull in the real timeout
reported by BlueZ.

BUG=b:29617227
TEST=request properties and check for the timeout

Committed: https://crrev.com/2b50d95a699ee444a4c3f7938a502abbf3d47ab8
Cr-Commit-Position: refs/heads/master@{#402302}

[Eric Caruso, 2016-06-23 22:54:43]

ejcaruso@chromium.org changed reviewers:
+ lhchavez@chromium.org

[Eric Caruso, 2016-06-23 22:54:44]

PTAL, thanks.

[Luis Héctor Chávez, 2016-06-24 15:43:24]

hmm you might have uncovered a build break. Can you see if rebasing helps?
(change lg, though).

[Eric Caruso, 2016-06-24 18:52:58]

Webkit tests are acting up right now. There's also some discussion on the
patchset I'm depending on about where to put the new functionality so this might
go back and forth a little bit :/

[Luis Héctor Chávez, 2016-06-24 19:17:10]

ok, so the change looks good. ping me once the change you depend on lands so i
can l-g-t-m this.

[Eric Caruso, 2016-06-24 20:47:06]

PTAL.

[Luis Héctor Chávez, 2016-06-24 20:53:36]

lgtm

[Eric Caruso, 2016-06-25 00:25:04]

The CQ bit was checked by ejcaruso@chromium.org

[commit-bot: I haz the power, 2016-06-25 00:25:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-25 00:52:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-25 00:52:12]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2016-06-27 17:10:49]

rockot@chromium.org changed reviewers:
+ rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-06-27 17:10:49]

https://codereview.chromium.org/2083423004/diff/100001/components/arc/bluetoo...
File components/arc/bluetooth/arc_bluetooth_bridge.cc (right):

https://codereview.chromium.org/2083423004/diff/100001/components/arc/bluetoo...
components/arc/bluetooth/arc_bluetooth_bridge.cc:1189:
btp->set_discovery_timeout(static_cast<bluez::BluetoothAdapterBlueZ*>(
drive-by comment: could you just store bluetooth_adapter_ as a
bluez::BluetoothAdapterBlueZ and do the downcast once in OnAdapterInitialized,
with a comment explaining why the downcast is safe?

[Ken Rockot(use gerrit already), 2016-06-27 17:15:38]

https://codereview.chromium.org/2083423004/diff/100001/components/arc.gypi
File components/arc.gypi (right):

https://codereview.chromium.org/2083423004/diff/100001/components/arc.gypi#ne...
components/arc.gypi:21: '../dbus/dbus.gyp:dbus',
also this target is missing a dependency on
'../device/bluetooth/bluetooth.gyp:bluetooth' which should get you the compiler
settings you need for dbus

[Ken Rockot(use gerrit already), 2016-06-27 17:15:55]

On 2016/06/27 at 17:15:38, Ken Rockot wrote:
> https://codereview.chromium.org/2083423004/diff/100001/components/arc.gypi
> File components/arc.gypi (right):
> 
>
https://codereview.chromium.org/2083423004/diff/100001/components/arc.gypi#ne...
> components/arc.gypi:21: '../dbus/dbus.gyp:dbus',
> also this target is missing a dependency on
'../device/bluetooth/bluetooth.gyp:bluetooth' which should get you the compiler
settings you need for dbus

(and no need to depend directly on either of those dbus targets you added)

[Eric Caruso, 2016-06-27 20:27:16]

The CQ bit was checked by ejcaruso@chromium.org

[Eric Caruso, 2016-06-27 20:27:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
lhchavez@chromium.org
Link to the patchset: https://codereview.chromium.org/2083423004/#ps80002
(title: "suggestions from rockot@")

[Eric Caruso, 2016-06-27 20:27:47]

The CQ bit was unchecked by ejcaruso@chromium.org

[Eric Caruso, 2016-06-27 20:27:54]

PTAL.

[commit-bot: I haz the power, 2016-06-27 20:27:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-06-27 20:40:21]

Thanks! lgtm

[Eric Caruso, 2016-06-27 21:15:28]

The CQ bit was checked by ejcaruso@chromium.org

[commit-bot: I haz the power, 2016-06-27 21:16:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 21:51:09]

Committed patchset #7 (id:80002)

[commit-bot: I haz the power, 2016-06-27 21:54:38]

Description was changed from

==========
arc/bluetooth: plumb adapter discoverable timeout property

Instead of hardcoding this to 120, we'll pull in the real timeout
reported by BlueZ.

BUG=b:29617227
TEST=request properties and check for the timeout
==========

to

==========
arc/bluetooth: plumb adapter discoverable timeout property

Instead of hardcoding this to 120, we'll pull in the real timeout
reported by BlueZ.

BUG=b:29617227
TEST=request properties and check for the timeout

Committed: https://crrev.com/2b50d95a699ee444a4c3f7938a502abbf3d47ab8
Cr-Commit-Position: refs/heads/master@{#402302}
==========

[commit-bot: I haz the power, 2016-06-27 21:54:39]

Patchset 7 (id:??) landed as
https://crrev.com/2b50d95a699ee444a4c3f7938a502abbf3d47ab8
Cr-Commit-Position: refs/heads/master@{#402302}