Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2083393002: Revert of Store mipmap levels in deferred texture image (Closed)

Created:
4 years, 6 months ago by Brian Osman
Modified:
4 years, 6 months ago
Reviewers:
cblume, bsalomon, ericrk
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@pipe-mipmap-levels-to-creation
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Store mipmap levels in deferred texture image (patchset #15 id:280001 of https://codereview.chromium.org/2034933003/ ) Reason for revert: Crashes on a few different bots (including ASAN). Examples: https://build.chromium.org/p/client.skia.android/builders/Test-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Release/builds/6324 https://build.chromium.org/p/client.skia/builders/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug/builds/5400 https://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-Golo-GPU-GT610-x86_64-Debug-ASAN/builds/3539 Original issue's description: > Store mipmap levels in deferred texture image > > When creating the deferred texture image, detect if using medium / high > quality. If so, generate and store mipmaps in the deferred texture > image. > > When creating a texture from that be sure to read it back out. > > BUG=578304 > R=bsalomon@google.com > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2034933003 > > Committed: https://skia.googlesource.com/skia/+/b3105190a6e02d37f1d7f07a3a8bdd368ec7f157 TBR=bsalomon@google.com,ericrk@chromium.org,cblume@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=578304 Committed: https://skia.googlesource.com/skia/+/6efeda4838f5944e4e14ff156be5593aa59cf1aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -230 lines) Patch
D gm/deferredtextureimage.cpp View 1 chunk +0 lines, -117 lines 0 comments Download
M include/core/SkImage.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/image/SkImage.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 9 chunks +7 lines, -99 lines 0 comments Download
M tests/ImageTest.cpp View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Osman
Created Revert of Store mipmap levels in deferred texture image
4 years, 6 months ago (2016-06-22 14:09:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083393002/1
4 years, 6 months ago (2016-06-22 14:10:03 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 14:10:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6efeda4838f5944e4e14ff156be5593aa59cf1aa

Powered by Google App Engine
This is Rietveld 408576698