Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2281)

Issue 2083383004: Flip 'Google Chrome Mac' builder on chromium.chrome back to GYP. (Closed)

Created:
4 years, 6 months ago by Dirk Pranke
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip 'Google Chrome Mac' builder on chromium.chrome back to GYP. Looks like dump_syms is broken ... TBR=rsesek@chromium.org, mark@chromium.org NOTRY=true BUG=622406 Committed: https://crrev.com/2daffdccc85520a52ddfaaf8739b3d08517ff1a9 Cr-Commit-Position: refs/heads/master@{#401362}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/mb/mb_config.pyl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Dirk Pranke
TBR/NOTRY since it's a build fix.
4 years, 6 months ago (2016-06-22 18:23:30 UTC) #2
Robert Sesek
lgtm
4 years, 6 months ago (2016-06-22 18:24:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083383004/1
4 years, 6 months ago (2016-06-22 18:24:44 UTC) #5
commit-bot: I haz the power
Failed to apply the patch.
4 years, 6 months ago (2016-06-22 18:33:23 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 18:36:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2daffdccc85520a52ddfaaf8739b3d08517ff1a9
Cr-Commit-Position: refs/heads/master@{#401362}

Powered by Google App Engine
This is Rietveld 408576698