Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2083383002: Remove calls to deprecated MessageLoop methods in google_apis. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in google_apis. This CL removes calls to deprecated methods MessageLoop::PostTask and MessageLoop::RunUntilIdle in google_apis. BUG=616447 TBR=rogerta@chromium.org Committed: https://crrev.com/aaa8bdbc629edda9f59548cf98bc811d7204aa8c Cr-Commit-Position: refs/heads/master@{#402600}

Patch Set 1 #

Patch Set 2 : manual change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M google_apis/gaia/oauth2_access_token_fetcher_immediate_error.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M google_apis/gaia/oauth2_token_service_request_unittest.cc View 7 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-22 17:37:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2083383002/20001
4 years, 5 months ago (2016-06-28 20:24:11 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-28 23:51:01 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 23:52:53 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aaa8bdbc629edda9f59548cf98bc811d7204aa8c
Cr-Commit-Position: refs/heads/master@{#402600}

Powered by Google App Engine
This is Rietveld 408576698