third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp - Issue 2083363003: Remove an unnecessary loop when converting scheme in NavigatorContentUtils

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp

Issue 2083363003: Remove an unnecessary loop when converting scheme in NavigatorContentUtils (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove an unnecessary loop when converting scheme in NavigatorContentUtils Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp

diff --git a/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp b/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp

index 8373c5d194c075ced04cde02449323544fe940b6..ccb2d8fc30b5046ec9fe023c268623bb4917876f 100644

--- a/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp

+++ b/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp

@@ -107,9 +107,7 @@ static bool isSchemeWhitelisted(const String& scheme)

initCustomSchemeHandlerWhitelist();

StringBuilder builder;

- unsigned length = scheme.length();

- for (unsigned i = 0; i < length; ++i)

- builder.append(toASCIILower(scheme[i]));

+ builder.append(scheme.lower().ascii().data());

return schemeWhitelist->contains(builder.toString());

}

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.idl » ('j') | no next file with comments »