Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(28)

Issue 2083363003: Remove an unnecessary loop when converting scheme in NavigatorContentUtils (Closed)

Created:
1 year, 10 months ago by gyuyoung2
Modified:
11 months, 2 weeks ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, gyuyoung2
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove an unnecessary loop when converting scheme in NavigatorContentUtils This CL is simple refactoring in order not to use an unnecessary loop in isSchemeWhitelisted() function. Additionally the spec url is updated because current one is outdated. TEST=http/tests/navigatorcontentutils BUG=none Committed: https://crrev.com/ee94bde91c72a046bec15436d56cfe32bb0e524c Cr-Commit-Position: refs/heads/master@{#401832}

Patch Set 1 : Remove an unnecessary loop when converting scheme in NavigatorContentUtils #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
gyuyoung2
PTAL
1 year, 9 months ago (2016-06-24 06:01:51 UTC) #4
haraken
LGTM
1 year, 9 months ago (2016-06-24 06:06:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083363003/20001
1 year, 9 months ago (2016-06-24 06:09:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
1 year, 9 months ago (2016-06-24 07:20:07 UTC) #9
commit-bot: I haz the power
1 year, 9 months ago (2016-06-24 07:21:25 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee94bde91c72a046bec15436d56cfe32bb0e524c
Cr-Commit-Position: refs/heads/master@{#401832}

Powered by Google App Engine
This is Rietveld 408576698