Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2083353002: Cache Object.create maps on the passed prototype's PrototypeInfo (Closed)

Created:
4 years, 6 months ago by Toon Verwaest
Modified:
4 years, 6 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Cache Object.create maps on the passed prototype's PrototypeInfo BUG=chromium:603144 Committed: https://crrev.com/059f2fa101a87c700066cccf33d5f580bde74a5f Cr-Commit-Position: refs/heads/master@{#37214}

Patch Set 1 #

Patch Set 2 : rebaseline #

Patch Set 3 : properly set prototype #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -3 lines) Patch
M src/bootstrapper.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M src/builtins.cc View 2 chunks +22 lines, -1 line 0 comments Download
M src/contexts.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 2 chunks +11 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +17 lines, -0 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallRuntime.golden View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
Toon Verwaest
ptal
4 years, 6 months ago (2016-06-22 13:15:23 UTC) #2
Igor Sheludko
lgtm
4 years, 6 months ago (2016-06-22 14:14:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083353002/20001
4 years, 6 months ago (2016-06-22 14:16:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/3601) v8_linux64_avx2_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 6 months ago (2016-06-22 14:34:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083353002/40001
4 years, 6 months ago (2016-06-23 11:48:30 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-23 12:16:52 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 12:19:20 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/059f2fa101a87c700066cccf33d5f580bde74a5f
Cr-Commit-Position: refs/heads/master@{#37214}

Powered by Google App Engine
This is Rietveld 408576698