Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 208333018: DNT should return 'null' if there is no client. (Closed)

Created:
6 years, 9 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 9 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

DNT should return 'null' if there is no client. BUG=347020 TEST=https://codereview.chromium.org/208243016/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170046

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M Source/modules/donottrack/NavigatorDoNotTrack.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
mlamouri (slow - plz ping)
6 years, 9 months ago (2014-03-24 16:15:32 UTC) #1
mlamouri (slow - plz ping)
Forgot to mention that I have a test for this in another CL. Will link ...
6 years, 9 months ago (2014-03-24 16:15:59 UTC) #2
jochen (gone - plz use gerrit)
can you add a test?
6 years, 9 months ago (2014-03-26 08:32:58 UTC) #3
mlamouri (slow - plz ping)
On 2014/03/26 08:32:58, jochen wrote: > can you add a test? Sorry, I should have ...
6 years, 9 months ago (2014-03-26 09:37:23 UTC) #4
jochen (gone - plz use gerrit)
lgtm
6 years, 9 months ago (2014-03-26 09:39:10 UTC) #5
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 9 months ago (2014-03-26 09:42:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/208333018/1
6 years, 9 months ago (2014-03-26 09:42:47 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 10:28:51 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-26 10:28:51 UTC) #9
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 9 months ago (2014-03-26 10:33:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/208333018/1
6 years, 9 months ago (2014-03-26 10:33:40 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 10:47:26 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-26 10:47:27 UTC) #13
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 9 months ago (2014-03-26 10:49:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/208333018/1
6 years, 9 months ago (2014-03-26 10:49:17 UTC) #15
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 11:55:22 UTC) #16
Message was sent while issue was closed. 
Change committed as 170046

Powered by Google App Engine
This is Rietveld 408576698