Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2083283002: Remove element handling from named path (Closed)

Created:
4 years, 6 months ago by Toon Verwaest
Modified:
4 years, 6 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove element handling from named path This was necessary since certain named handlers didn't check the name beforehand, and could miss to LoadIC_Miss with a name convertible to an index. This is currently not supported anymore, so we can drop this path. We should make sure we miss to the right label instead. BUG= Committed: https://crrev.com/bedcc31b834f949c131d749828ff7b0b720087b4 Cr-Commit-Position: refs/heads/master@{#37174}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -37 lines) Patch
M src/ic/ic.cc View 3 chunks +4 lines, -37 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 6 months ago (2016-06-22 07:43:18 UTC) #2
Igor Sheludko
lgtm
4 years, 6 months ago (2016-06-22 08:14:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083283002/1
4 years, 6 months ago (2016-06-22 08:51:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 09:19:45 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 09:22:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bedcc31b834f949c131d749828ff7b0b720087b4
Cr-Commit-Position: refs/heads/master@{#37174}

Powered by Google App Engine
This is Rietveld 408576698