RecentTabHelper: Move URL checking logic into DidFinishNavigation.

RecentTabHelper: Move URL checking logic into DidFinishNavigation.

We need to prevent saving certain types of pages, moving into DidFinishNavigation
prevents the SnapshotController from even starting; this is better than waiting
for the right moment detector to fire before we check that snapshots are OK for
this page.

BUG=622424
Committed: https://crrev.com/db78ec298290c1e8d6aefdee02af036ee3647438
Cr-Commit-Position: refs/heads/master@{#401766}

[dewittj, 2016-06-23 18:21:54]

Description was changed from

==========
RecentTabHelper: Move URL checking logic into DidFinishNavigation.

We need to prevent saving certain types of pages, moving into
DidFinishNavigation
prevents the SnapshotController from even starting; this is better than waiting
for the right moment detector to fire before we check that snapshots are OK for
this page.

BUG=622424
==========

to

==========
RecentTabHelper: Move URL checking logic into DidFinishNavigation.

We need to prevent saving certain types of pages, moving into
DidFinishNavigation
prevents the SnapshotController from even starting; this is better than waiting
for the right moment detector to fire before we check that snapshots are OK for
this page.

BUG=622424
==========

[dewittj, 2016-06-23 18:21:54]

dewittj@chromium.org changed reviewers:
+ dimich@chromium.org, jianli@chromium.org

[dewittj, 2016-06-23 18:22:15]

dimich: ptal
jianli: fyi/review if you prefer :)

[Dmitry Titov, 2016-06-24 00:51:39]

lgtm

[dewittj, 2016-06-24 00:53:07]

The CQ bit was checked by dewittj@chromium.org

[commit-bot: I haz the power, 2016-06-24 00:53:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2083273004/20001

[commit-bot: I haz the power, 2016-06-24 01:00:40]

Description was changed from

==========
RecentTabHelper: Move URL checking logic into DidFinishNavigation.

We need to prevent saving certain types of pages, moving into
DidFinishNavigation
prevents the SnapshotController from even starting; this is better than waiting
for the right moment detector to fire before we check that snapshots are OK for
this page.

BUG=622424
==========

to

==========
RecentTabHelper: Move URL checking logic into DidFinishNavigation.

We need to prevent saving certain types of pages, moving into
DidFinishNavigation
prevents the SnapshotController from even starting; this is better than waiting
for the right moment detector to fire before we check that snapshots are OK for
this page.

BUG=622424
==========

[commit-bot: I haz the power, 2016-06-24 01:00:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-24 01:02:35]

Description was changed from

==========
RecentTabHelper: Move URL checking logic into DidFinishNavigation.

We need to prevent saving certain types of pages, moving into
DidFinishNavigation
prevents the SnapshotController from even starting; this is better than waiting
for the right moment detector to fire before we check that snapshots are OK for
this page.

BUG=622424
==========

to

==========
RecentTabHelper: Move URL checking logic into DidFinishNavigation.

We need to prevent saving certain types of pages, moving into
DidFinishNavigation
prevents the SnapshotController from even starting; this is better than waiting
for the right moment detector to fire before we check that snapshots are OK for
this page.

BUG=622424

Committed: https://crrev.com/db78ec298290c1e8d6aefdee02af036ee3647438
Cr-Commit-Position: refs/heads/master@{#401766}
==========

[commit-bot: I haz the power, 2016-06-24 01:02:36]

Patchset 2 (id:??) landed as
https://crrev.com/db78ec298290c1e8d6aefdee02af036ee3647438
Cr-Commit-Position: refs/heads/master@{#401766}