Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 208323012: Mark dashing_gpu and complexclip2_rect_aa_gpu as ignore-failure on Win7 perspective (Closed)

Created:
6 years, 9 months ago by borenet
Modified:
6 years, 9 months ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Mark dashing_gpu and complexclip2_rect_aa_gpu as ignore-failure on Win7 perspective BUG=skia:2245 Committed: http://code.google.com/p/skia/source/detail?r=13924

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add bug numbers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json View 1 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
borenet
6 years, 9 months ago (2014-03-24 18:13:07 UTC) #1
epoger
https://codereview.chromium.org/208323012/diff/1/expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json File expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json (right): https://codereview.chromium.org/208323012/diff/1/expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json#newcode3793 expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json:3793: "ignore-failure": true, It worries me to mark results as ...
6 years, 9 months ago (2014-03-24 18:36:02 UTC) #2
borenet
Filed new bugs, uploaded patch set 2.
6 years, 9 months ago (2014-03-24 19:01:09 UTC) #3
epoger
LGTM Thanks for doing that.
6 years, 9 months ago (2014-03-24 19:27:41 UTC) #4
borenet
On 2014/03/24 19:27:41, epoger wrote: > LGTM > > Thanks for doing that. No problem. ...
6 years, 9 months ago (2014-03-24 19:28:48 UTC) #5
borenet
The CQ bit was checked by borenet@google.com
6 years, 9 months ago (2014-03-24 19:28:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/208323012/20001
6 years, 9 months ago (2014-03-24 19:28:54 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 20:58:24 UTC) #8
Message was sent while issue was closed.
Change committed as 13924

Powered by Google App Engine
This is Rietveld 408576698