Source/core/rendering/svg/RenderSVGEllipse.cpp - Issue 208323007: Fix getBBox() returning (0,0) bug when width or height is zero

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/RenderSVGEllipse.cpp

Issue 208323007: Fix getBBox() returning (0,0) bug when width or height is zero (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@myzbackup

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/svg/custom/getBBox-rect-has-one-zero-value-expected.txt ('k') | Source/core/rendering/svg/RenderSVGRect.cpp » ('j') | Source/core/rendering/svg/SVGPathData.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/svg/RenderSVGEllipse.cpp

diff --git a/Source/core/rendering/svg/RenderSVGEllipse.cpp b/Source/core/rendering/svg/RenderSVGEllipse.cpp

index bcd290028b12c6c03e958d032323cc9d88f77976..bc3cfaea44be297b3752b1b772ab79e5cb10d9ea 100644

--- a/Source/core/rendering/svg/RenderSVGEllipse.cpp

+++ b/Source/core/rendering/svg/RenderSVGEllipse.cpp

@@ -63,8 +63,8 @@ void RenderSVGEllipse::updateShapeFromElement()

calculateRadiiAndCenter();

- // Spec: "A value of zero disables rendering of the element."

- if (m_radii.width() <= 0 || m_radii.height() <= 0)

+ // Spec: "A negative value is an error. A value of zero disables rendering of the element."

+ if (m_radii.isZero() || m_radii.width() < 0 || m_radii.height() < 0)

return;

m_fillBoundingBox = FloatRect(m_center.x() - m_radii.width(), m_center.y() - m_radii.height(), 2 * m_radii.width(), 2 * m_radii.height());