Fix getBBox() returning (0,0) bug when width or height is zero

Source/core/rendering/svg/SVGPathData.cpp

 /*
  * Copyright (C) Research In Motion Limited 2011. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 32 matching lines @@
     if (r > 0)
         path.addEllipse(FloatRect(circle->cx()->currentValue()->value(lengthContext) - r, circle->cy()->currentValue()->value(lengthContext) - r, r * 2, r * 2));
 }
 
 static void updatePathFromEllipseElement(SVGElement* element, Path& path)
 {
     SVGEllipseElement* ellipse = toSVGEllipseElement(element);
 
     SVGLengthContext lengthContext(element);
     float rx = ellipse->rx()->currentValue()->value(lengthContext);
-    if (rx <= 0)
+    if (rx < 0)
         return;
     float ry = ellipse->ry()->currentValue()->value(lengthContext);
-    if (ry <= 0)
+    if (ry < 0)
         return;
+    if (!(rx || ry))

[pdr., 2014/03/26 00:55:41]

It took me a minute to understand this codechange. Could we fold the negation in
like so:
if (!rx && !ry)
  return;

+        return;
+
     path.addEllipse(FloatRect(ellipse->cx()->currentValue()->value(lengthContext) - rx, ellipse->cy()->currentValue()->value(lengthContext) - ry, rx * 2, ry * 2));
 }
 
 static void updatePathFromLineElement(SVGElement* element, Path& path)
 {
     SVGLineElement* line = toSVGLineElement(element);
 
     SVGLengthContext lengthContext(element);
     path.moveTo(FloatPoint(line->x1()->currentValue()->value(lengthContext), line->y1()->currentValue()->value(lengthContext)));
     path.addLineTo(FloatPoint(line->x2()->currentValue()->value(lengthContext), line->y2()->currentValue()->value(lengthContext)));
@@ skipping 25 matching lines @@
     updatePathFromPolylineElement(element, path);
     path.closeSubpath();
 }
 
 static void updatePathFromRectElement(SVGElement* element, Path& path)
 {
     SVGRectElement* rect = toSVGRectElement(element);
 
     SVGLengthContext lengthContext(element);
     float width = rect->width()->currentValue()->value(lengthContext);
-    if (width <= 0)
+    if (width < 0)
         return;
     float height = rect->height()->currentValue()->value(lengthContext);
-    if (height <= 0)
+    if (height < 0)
+        return;
+    if (!(width || height))

[pdr., 2014/03/26 00:55:41]

Similarly here, can you fold the negation into the parens for readability?

         return;
     float x = rect->x()->currentValue()->value(lengthContext);
     float y = rect->y()->currentValue()->value(lengthContext);
     float rx = rect->rx()->currentValue()->value(lengthContext);
     float ry = rect->ry()->currentValue()->value(lengthContext);
     bool hasRx = rx > 0;
     bool hasRy = ry > 0;
     if (hasRx || hasRy) {
         if (!hasRx)
             rx = ry;
@@ skipping 23 matching lines @@
         map->set(SVGNames::polygonTag.localName().impl(), updatePathFromPolygonElement);
         map->set(SVGNames::polylineTag.localName().impl(), updatePathFromPolylineElement);
         map->set(SVGNames::rectTag.localName().impl(), updatePathFromRectElement);
     }
 
     if (PathUpdateFunction pathUpdateFunction = map->get(element->localName().impl()))
         (*pathUpdateFunction)(element, path);
 }
 
 } // namespace WebCore