Issue 208323003: Add support for attribute selectors in TargetedStyleRecalc.

Issue 208323003: Add support for attribute selectors in TargetedStyleRecalc. (Closed)

Created:
6 years, 9 months ago by chrishtr

Modified:
6 years, 9 months ago

Reviewers:
esprehn, rune

CC:
blink-reviews, sof, eae+blinkwatch, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, rune+blink, Inactive, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Add support for attribute selectors in TargetedStyleRecalc. Like with classes, even if local TargetedStyleRecalc is not supported for an attribute selector, this also causes style invalidation tree walks rather than setting style recalc dirty bits directly. BUG=339729, 352300 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169793

Patch Set 1 #

Patch Set 2 : Finish implementation. #

Patch Set 3 : Small fixes. #

Patch Set 4 : More fixes & simplifications. #

Patch Set 5 : Small tweak #

Patch Set 6 : Tweaks. #

Total comments: 4

Patch Set 7 : Addressed comments from esprehn@ #

Patch Set 8 : Fix compilation #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+131 lines, -66 lines)			Patch
A +	LayoutTests/fast/css/invalidation/targeted-attribute-style-invalidation.html	View	1 2	5 chunks	+9 lines, -9 lines	0 comments	Download
A +	LayoutTests/fast/css/invalidation/targeted-attribute-style-invalidation-expected.txt	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/css/RuleFeature.h	View	1 2 3 4 5 6	7 chunks	+16 lines, -8 lines	0 comments	Download
M	Source/core/css/RuleFeature.cpp	View	1 2 3 4 5 6	13 chunks	+53 lines, -35 lines	0 comments	Download
M	Source/core/css/analyzer/DescendantInvalidationSet.h	View	1 2 3 4 5 6	3 chunks	+6 lines, -0 lines	0 comments	Download
M	Source/core/css/analyzer/DescendantInvalidationSet.cpp	View	1	5 chunks	+29 lines, -0 lines	0 comments	Download
M	Source/core/css/invalidation/StyleInvalidator.h	View		3 chunks	+3 lines, -0 lines	0 comments	Download
M	Source/core/css/invalidation/StyleInvalidator.cpp	View	1	1 chunk	+13 lines, -7 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolver.cpp	View	1 2 3 4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Element.cpp	View	1 2 3	2 chunks	+2 lines, -7 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

esprehn

lgtm, some nits. Please fix before landing. btw, it's nice if you wrap your description ...

6 years, 9 months ago (2014-03-21 23:01:44 UTC) #2

chrishtr

https://codereview.chromium.org/208323003/diff/90001/Source/core/css/RuleFeature.cpp File Source/core/css/RuleFeature.cpp (right): https://codereview.chromium.org/208323003/diff/90001/Source/core/css/RuleFeature.cpp#newcode198 Source/core/css/RuleFeature.cpp:198: void RuleFeatureSet::addAttributeFromAContentAttrValue(const AtomicString& attributeName) On 2014/03/21 23:01:44, esprehn wrote: ...

6 years, 9 months ago (2014-03-21 23:11:21 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/208323003/120001

6 years, 9 months ago (2014-03-22 05:12:35 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/208323003/120001

6 years, 9 months ago (2014-03-22 16:37:07 UTC) #8

Message was sent while issue was closed.

Change committed as 169793

Expand Messages | Collapse Messages