tracing/tracing/ui/extras/side_panel/input_latency_side_panel.html - Issue 2083213002: Change call-sites in trace viewer to use generators instead of iteration functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/extras/side_panel/input_latency_side_panel.html

Issue 2083213002: Change call-sites in trace viewer to use generators instead of iteration functions. (Closed) Base URL: git@github.com:catapult-project/catapult@master

Patch Set: fix nits, rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/ui/extras/chrome/cc/layer_tree_quad_stack_view.html ('k') | tracing/tracing/ui/tracks/cpu_usage_track.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/ui/extras/side_panel/input_latency_side_panel.html

diff --git a/tracing/tracing/ui/extras/side_panel/input_latency_side_panel.html b/tracing/tracing/ui/extras/side_panel/input_latency_side_panel.html

index 2b42df37e5161cc4e91acbfb55eb147846865062..4b3a9a5917bb0979322a311355860ab10072b0df 100644

--- a/tracing/tracing/ui/extras/side_panel/input_latency_side_panel.html

+++ b/tracing/tracing/ui/extras/side_panel/input_latency_side_panel.html

@@ -119,12 +119,10 @@ found in the LICENSE file.

// Based on the brushed range, update the selection of LatencyInfo in

// the timeline view by sending a selectionChange event.

var latencySlices = [];

- this.model_.getAllThreads().forEach(function(thread) {

- thread.iterateAllEvents(function(event) {

+ for (var thread of this.model_.getAllThreads())

+ for (var event of thread.getDescendantEvents())

if (event.title.indexOf('InputLatency:') === 0)

latencySlices.push(event);

- });

latencySlices = tr.model.helpers.getSlicesIntersectingRange(

r, latencySlices);