tracing/tracing/model/user_model/user_model.html - Issue 2083213002: Change call-sites in trace viewer to use generators instead of iteration functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/model/user_model/user_model.html

Issue 2083213002: Change call-sites in trace viewer to use generators instead of iteration functions. (Closed) Base URL: git@github.com:catapult-project/catapult@master

Patch Set: fix nits, rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tracing/tracing/model/user_model/user_model.html

diff --git a/tracing/tracing/model/user_model/user_model.html b/tracing/tracing/model/user_model/user_model.html

index a4188ece21e4c8f5aab2c19ed9a7df832b5f4ec3..fd30d6a610b113da9c1da2557e0e0d2201b7c108 100644

--- a/tracing/tracing/model/user_model/user_model.html

+++ b/tracing/tracing/model/user_model/user_model.html

@@ -44,13 +44,8 @@ tr.exportTo('tr.model.um', function() {

addCategoriesToDict: function(categoriesDict) {

- findTopmostSlicesInThisContainer: function(eventPredicate, callback,

- opt_this) {

- },

- childEvents: function*(eventTypePredicate, opt_this) {

- if (eventTypePredicate.call(opt_this, tr.model.um.UserExpectation))

- yield * this.expectations;

+ childEvents: function*() {

+ yield * this.expectations;

childEventContainers: function*() {

« no previous file with comments | « tracing/tracing/model/thread.html ('k') | tracing/tracing/ui/brushing_state.html » ('j') | no next file with comments »