Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1816)

Unified Diff: tracing/tracing/model/async_slice.html

Issue 2083213002: Change call-sites in trace viewer to use generators instead of iteration functions. (Closed) Base URL: git@github.com:catapult-project/catapult@master
Patch Set: fix nits, rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/metrics/v8/execution_metric.html ('k') | tracing/tracing/model/async_slice_group.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/model/async_slice.html
diff --git a/tracing/tracing/model/async_slice.html b/tracing/tracing/model/async_slice.html
index 28aa8977f6d060c33637097acf401961ddac3fd7..325ef09d0a866a96620ce3215fe933654a486416 100644
--- a/tracing/tracing/model/async_slice.html
+++ b/tracing/tracing/model/async_slice.html
@@ -103,16 +103,13 @@ tr.exportTo('tr.model', function() {
parentAsyncSliceGroup.slices.indexOf(this);
},
- findTopmostSlicesRelativeToThisSlice: function(eventPredicate, callback,
- opt_this) {
- if (eventPredicate(this))
- callback.call(opt_this, this);
- else {
- this.subSlices.forEach(function(s) {
- s.findTopmostSlicesRelativeToThisSlice(eventPredicate, callback,
- opt_this);
- });
+ findTopmostSlicesRelativeToThisSlice: function*(eventPredicate, opt_this) {
+ if (eventPredicate(this)) {
+ yield this;
+ return;
}
+ for (var s of this.subSlices)
+ yield * s.findTopmostSlicesRelativeToThisSlice(eventPredicate);
},
findDescendentSlice: function(targetTitle) {
« no previous file with comments | « tracing/tracing/metrics/v8/execution_metric.html ('k') | tracing/tracing/model/async_slice_group.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698