trace_processor/experimental/mappers/slice_cost.html - Issue 2083213002: Change call-sites in trace viewer to use generators instead of iteration functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trace_processor/experimental/mappers/slice_cost.html

Issue 2083213002: Change call-sites in trace viewer to use generators instead of iteration functions. (Closed) Base URL: git@github.com:catapult-project/catapult@master

Patch Set: fix nits, rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « trace_processor/experimental/mappers/scheduling/map_wake_ups.html ('k') | trace_processor/experimental/mappers/thread_grouping_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: trace_processor/experimental/mappers/slice_cost.html

diff --git a/trace_processor/experimental/mappers/slice_cost.html b/trace_processor/experimental/mappers/slice_cost.html

index 6a143492416ce32a189fd2d4457e1ededaa78245..8860f87c7001aa16cc396ab1a75d72045a79d3a1 100644

--- a/trace_processor/experimental/mappers/slice_cost.html

+++ b/trace_processor/experimental/mappers/slice_cost.html

@@ -137,16 +137,16 @@ tr.exportTo('pi.m', function() {

});

}

- model.iterateAllEvents(function(event) {

+ for (var event of model.descendentEvents()) {

if (!(event instanceof tr.model.ThreadSlice))

- return;

+ continue;

if (filterFunction && !filterFunction(event))

- return;

+ continue;

var threadSlice = event;

if (threadSlice.title === 'V8.Execute') {

generateDomainCosts(threadSlice);

- return;

+ continue;

}

var sliceCostInfo = new SliceCostInfo();

@@ -166,7 +166,7 @@ tr.exportTo('pi.m', function() {

sliceCostInfo.railTypeName + '/' +

sliceCostInfo.title;

reduce.push(key, sliceCostInfo);

- });

+ }

var sliceCostInfos = [];

reduce.finalizeAndIterResults(function(key, sliceCostInfo) {