Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: trace_processor/experimental/mappers/trace_import_cost.html

Issue 2083213002: Change call-sites in trace viewer to use generators instead of iteration functions. (Closed) Base URL: git@github.com:catapult-project/catapult@master
Patch Set: fix nits, rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 Copyright (c) 2015 The Chromium Authors. All rights reserved. 3 Copyright (c) 2015 The Chromium Authors. All rights reserved.
4 Use of this source code is governed by a BSD-style license that can be 4 Use of this source code is governed by a BSD-style license that can be
5 found in the LICENSE file. 5 found in the LICENSE file.
6 --> 6 -->
7 7
8 <link rel="import" href="/perf_insights/mappers/reduce.html"> 8 <link rel="import" href="/perf_insights/mappers/reduce.html">
9 <link rel="import" href="/perf_insights/mre/function_handle.html"> 9 <link rel="import" href="/perf_insights/mre/function_handle.html">
10 <link rel="import" href="/tracing/extras/measure/measure.html"> 10 <link rel="import" href="/tracing/extras/measure/measure.html">
(...skipping 14 matching lines...) Expand all
25 }; 25 };
26 cost_infos.push(cost_info); 26 cost_infos.push(cost_info);
27 var subSlices = slice.subSlices; 27 var subSlices = slice.subSlices;
28 for (var i = 0; i < subSlices.length; ++i) { 28 for (var i = 0; i < subSlices.length; ++i) {
29 fetchSlicesInfo(subSlices[i], cost_info.subSlices); 29 fetchSlicesInfo(subSlices[i], cost_info.subSlices);
30 } 30 }
31 } 31 }
32 32
33 function getTraceImportCostReport(result, model) { 33 function getTraceImportCostReport(result, model) {
34 var top_level_slices = []; 34 var top_level_slices = [];
35 model.iterateAllEvents(function(event) { 35 for (var event of model.getDescendantEvents()) {
36 if (event instanceof MeasureAsyncSlice && 36 if (event instanceof MeasureAsyncSlice &&
37 event.viewSubGroupTitle === 'TraceImport' && 37 event.viewSubGroupTitle === 'TraceImport' &&
38 event.isTopLevel) { 38 event.isTopLevel) {
39 top_level_slices.push(event); 39 top_level_slices.push(event);
40 } 40 }
41 }); 41 }
42 var traceImportCostInfos = []; 42 var traceImportCostInfos = [];
43 for (var i = 0; i < top_level_slices.length; ++i) { 43 for (var i = 0; i < top_level_slices.length; ++i) {
44 fetchSlicesInfo(top_level_slices[i], traceImportCostInfos); 44 fetchSlicesInfo(top_level_slices[i], traceImportCostInfos);
45 } 45 }
46 46
47 result.addPair('trace_import_cost_info', 47 result.addPair('trace_import_cost_info',
48 {'slices': traceImportCostInfos}); 48 {'slices': traceImportCostInfos});
49 } 49 }
50 50
51 pi.FunctionRegistry.register(getTraceImportCostReport); 51 pi.FunctionRegistry.register(getTraceImportCostReport);
52 52
53 return { 53 return {
54 getTraceImportCostReport: getTraceImportCostReport 54 getTraceImportCostReport: getTraceImportCostReport
55 }; 55 };
56 }); 56 });
57 </script> 57 </script>
OLDNEW
« no previous file with comments | « trace_processor/experimental/mappers/thread_grouping_test.html ('k') | trace_processor/experimental/mappers/trace_stats.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698