IndexedDB: Ensure transactions without requests commit in the same order

content/browser/indexed_db/indexed_db_transaction.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/indexed_db/indexed_db_transaction.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/single_thread_task_runner.h"
@@ skipping 180 matching lines @@
 }
 
 void IndexedDBTransaction::RegisterOpenCursor(IndexedDBCursor* cursor) {
   open_cursors_.insert(cursor);
 }
 
 void IndexedDBTransaction::UnregisterOpenCursor(IndexedDBCursor* cursor) {
   open_cursors_.erase(cursor);
 }
 
+namespace {
+void CommitUnused(scoped_refptr<IndexedDBTransaction> transaction) {

[cmumford, 2016/06/22 16:53:37]

Do you want an anonymous namespace inside of the "content" namespace? Top of
file? I'm not sure what is correct here.

[jsbell, 2016/06/22 18:53:04]

Yeah, we mostly put anon/helpers at the top, so moved. And added a comment.

+  leveldb::Status status = transaction->Commit();
+  DCHECK(status.ok());
+}
+}  // namespace
+
 void IndexedDBTransaction::Start() {
   // TransactionCoordinator has started this transaction.
   DCHECK_EQ(CREATED, state_);
   state_ = STARTED;
   diagnostics_.start_time = base::Time::Now();
 
-  if (!used_)
+  if (!used_) {
+    if (commit_pending_) {
+      // The transaction has never had requests issued against it,
+      // but the front-end requested a commit initiate the commit

[cmumford, 2016/06/22 16:53:37]

Nit: oddly worded "commit initiate the commit".

[jsbell, 2016/06/22 18:53:04]

Fixed, thx.

+      // but not re-entrantly as that may renter the coordinator.
+      base::ThreadTaskRunnerHandle::Get()->PostTask(
+          FROM_HERE, base::Bind(&CommitUnused, make_scoped_refptr(this)));
+    }
     return;
+  }
 
   RunTasksIfStarted();
 }
 
 class BlobWriteCallbackImpl : public IndexedDBBackingStore::BlobWriteCallback {
  public:
   explicit BlobWriteCallbackImpl(
       scoped_refptr<IndexedDBTransaction> transaction)
       : transaction_(transaction) {}
   void Run(bool succeeded) override {
@@ skipping 27 matching lines @@
   // In multiprocess ports, front-end may have requested a commit but
   // an abort has already been initiated asynchronously by the
   // back-end.
   if (state_ == FINISHED)
     return leveldb::Status::OK();
   DCHECK_NE(state_, COMMITTING);
 
   DCHECK(!used_ || state_ == STARTED);
   commit_pending_ = true;
 
+  if (state_ != STARTED)

[cmumford, 2016/06/22 16:53:37]

Nit: Possibly worthy of a short comment - your call.

[jsbell, 2016/06/22 18:53:04]

Done.

+    return leveldb::Status::OK();
+
   // Front-end has requested a commit, but there may be tasks like
   // create_index which are considered synchronous by the front-end
   // but are processed asynchronously.
   if (HasPendingTasks())
     return leveldb::Status::OK();
 
   state_ = COMMITTING;
 
   leveldb::Status s;
   if (!used_) {
@@ skipping 148 matching lines @@
 }
 
 void IndexedDBTransaction::CloseOpenCursors() {
   IDB_TRACE1("IndexedDBTransaction::CloseOpenCursors", "txn.id", id());
   for (auto* cursor : open_cursors_)
     cursor->Close();
   open_cursors_.clear();
 }
 
 }  // namespace content