Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: src/string-stream.cc

Issue 2083163003: Don't crash when trying to print a call stack of an OOM. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/string-stream.cc
diff --git a/src/string-stream.cc b/src/string-stream.cc
index 86aaac5ce0d4e26979e318459cb3c8db26a551d7..781f8cd6bf2d5ba1a4401e7b6b177766160ab29d 100644
--- a/src/string-stream.cc
+++ b/src/string-stream.cc
@@ -528,7 +528,7 @@ void StringStream::PrintPrototype(JSFunction* fun, Object* receiver) {
bool print_name = false;
Isolate* isolate = fun->GetIsolate();
if (receiver->IsNull(isolate) || receiver->IsUndefined(isolate) ||
- receiver->IsJSProxy()) {
+ receiver->IsTheHole(isolate) || receiver->IsJSProxy()) {
print_name = true;
} else if (isolate->context() != nullptr) {
if (!receiver->IsJSObject()) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698