Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 2083163003: Don't crash when trying to print a call stack of an OOM. (Closed)

Created:
4 years, 6 months ago by Igor Sheludko
Modified:
4 years, 6 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't crash when trying to print a call stack of an OOM. Receiver is the hole when we construct a builtin object. BUG=chromium:611684 Committed: https://crrev.com/bbbf21c240918ef70384c58d5aaa2ee12af6bfc1 Cr-Commit-Position: refs/heads/master@{#37182}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/string-stream.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083163003/1
4 years, 6 months ago (2016-06-22 10:56:40 UTC) #2
Igor Sheludko
PTAL
4 years, 6 months ago (2016-06-22 10:56:51 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-22 11:19:03 UTC) #6
Toon Verwaest
lgtm
4 years, 6 months ago (2016-06-22 11:19:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083163003/1
4 years, 6 months ago (2016-06-22 11:20:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 11:22:56 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 11:24:23 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bbbf21c240918ef70384c58d5aaa2ee12af6bfc1
Cr-Commit-Position: refs/heads/master@{#37182}

Powered by Google App Engine
This is Rietveld 408576698