Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2083153004: Revert of Include file names in trace_turbo output (Closed)

Created:
4 years, 6 months ago by mattloring
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Include file names in trace_turbo output (patchset #3 id:40001 of https://codereview.chromium.org/2083863004/ ) Reason for revert: Many build bots are failing with a message of the form: Missing or invalid v8 JSON file: /tmp/tmp2qcEUy_swarming/0/output.json Can be relanded once we understand why these failures are occuring. Original issue's description: > Include file names in trace_turbo output > > The trace turbo output will overwrite itself when functions in different > files share the same name. Output files now have the form > `turbo-<function_name>:<opt_file_name>-<opt_phase>.suffix`. > > R=ofrobots@google.com > BUG= > > Committed: https://crrev.com/a53b9bf02f31e5647c37e0392afa19f74df1a3ba > Cr-Commit-Position: refs/heads/master@{#37199} TBR=ofrobots@google.com,bmeurer@chromium.org,danno@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/97c2bc362f234bd58515a0faf6af23b4f8ad183a Cr-Commit-Position: refs/heads/master@{#37204}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -21 lines) Patch
M src/compiler/graph-visualizer.cc View 1 chunk +3 lines, -20 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
mattloring
Created Revert of Include file names in trace_turbo output
4 years, 6 months ago (2016-06-22 20:46:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083153004/1
4 years, 6 months ago (2016-06-22 20:46:25 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-06-22 20:46:27 UTC) #5
mattloring
The error messages from the build bots were of the form: Missing or invalid v8 ...
4 years, 6 months ago (2016-06-22 20:53:57 UTC) #6
mattloring
What steps should I have taken to avoid this issue before landing?
4 years, 6 months ago (2016-06-22 22:17:40 UTC) #8
ofrobots
On 2016/06/22 22:17:40, mattloring wrote: > What steps should I have taken to avoid this ...
4 years, 6 months ago (2016-06-22 22:20:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083153004/1
4 years, 6 months ago (2016-06-22 22:20:54 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 22:21:11 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/97c2bc362f234bd58515a0faf6af23b4f8ad183a Cr-Commit-Position: refs/heads/master@{#37204}
4 years, 6 months ago (2016-06-22 22:24:02 UTC) #15
mattloring
4 years, 6 months ago (2016-06-22 22:59:04 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2081323007/ by mattloring@google.com.

The reason for reverting is: Ready to test fix and reland..

Powered by Google App Engine
This is Rietveld 408576698