Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 2083153002: [Mac/GN] Let //chrome/browser:browser be a static library. (Closed)

Created:
4 years, 6 months ago by Robert Sesek
Modified:
4 years, 5 months ago
Reviewers:
brettw, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Let //chrome/browser:browser be a static library. This requires //chrome:chrome_framework to link with -ObjC to force categories to load from static archives. BUG=618797 R=brettw@chromium.org Committed: https://crrev.com/d4ee99258720a95788c8465aef4562c479872f03 Cr-Commit-Position: refs/heads/master@{#402836}

Patch Set 1 #

Patch Set 2 : global -ObjC #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M build/config/mac/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 17 (4 generated)
Robert Sesek
4 years, 6 months ago (2016-06-21 21:32:39 UTC) #1
brettw
LGTM, but is this a more general thing that should apply more widely to all ...
4 years, 6 months ago (2016-06-21 22:51:46 UTC) #2
Robert Sesek
On 2016/06/21 22:51:46, brettw wrote: > LGTM, but is this a more general thing that ...
4 years, 6 months ago (2016-06-21 23:19:50 UTC) #4
Nico
On 2016/06/21 23:19:50, Robert Sesek wrote: > On 2016/06/21 22:51:46, brettw wrote: > > LGTM, ...
4 years, 6 months ago (2016-06-22 14:08:35 UTC) #5
brettw
There are two configs: //build/config/mac:mac_dynamic_flags which are applied to executables, shared libraries, and loadable modules. ...
4 years, 6 months ago (2016-06-22 18:12:39 UTC) #6
Nico
Yes. On Wed, Jun 22, 2016 at 2:12 PM, <brettw@chromium.org> wrote: > There are two ...
4 years, 6 months ago (2016-06-22 18:20:48 UTC) #7
Robert Sesek
Another option would be to define a new config like "contains_objc_category" that could be set ...
4 years, 6 months ago (2016-06-22 18:22:06 UTC) #8
brettw
Are there any downsides to specifying this flag when it's not necessary?
4 years, 6 months ago (2016-06-22 18:23:34 UTC) #9
Robert Sesek
On 2016/06/22 18:23:34, brettw wrote: > Are there any downsides to specifying this flag when ...
4 years, 6 months ago (2016-06-22 22:32:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2083153002/20001
4 years, 5 months ago (2016-06-29 15:37:25 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-29 16:44:54 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 16:45:41 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 16:49:02 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d4ee99258720a95788c8465aef4562c479872f03
Cr-Commit-Position: refs/heads/master@{#402836}

Powered by Google App Engine
This is Rietveld 408576698