Issue 208313017: Add GM that tests GrTextureDomain and fix bug where kDecal_Mode gets incorrectly ignored.

Issue 208313017: Add GM that tests GrTextureDomain and fix bug where kDecal_Mode gets incorrectly ignored. (Closed)

Created:
6 years, 9 months ago by bsalomon

Modified:
6 years, 9 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add GM that tests GrTextureDomain and fix bug where kDecal_Mode gets incorrectly ignored. Committed: http://code.google.com/p/skia/source/detail?r=13933

Patch Set 3 : Address comments and use gradients to init texture rather than noise. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+160 lines, -1 line)			Patch
A	gm/texturedomaineffect.cpp	View	1 2	1 chunk	+158 lines, -0 lines	0 comments	Download
M	gyp/gmslides.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/gpu/effects/GrTextureDomain.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm https://codereview.chromium.org/208313017/diff/20001/gm/texturedomaineffect.cpp File gm/texturedomaineffect.cpp (right): https://codereview.chromium.org/208313017/diff/20001/gm/texturedomaineffect.cpp#newcode23 gm/texturedomaineffect.cpp:23: /** Fix comment? https://codereview.chromium.org/208313017/diff/20001/gm/texturedomaineffect.cpp#newcode97 gm/texturedomaineffect.cpp:97: SkRect renderRect = ...

6 years, 9 months ago (2014-03-25 12:12:38 UTC) #2

bsalomon

https://codereview.chromium.org/208313017/diff/20001/gm/texturedomaineffect.cpp File gm/texturedomaineffect.cpp (right): https://codereview.chromium.org/208313017/diff/20001/gm/texturedomaineffect.cpp#newcode23 gm/texturedomaineffect.cpp:23: /** On 2014/03/25 12:12:40, robertphillips wrote: > Fix comment? ...

6 years, 9 months ago (2014-03-25 14:36:36 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/208313017/40001

6 years, 9 months ago (2014-03-25 14:36:41 UTC) #5

Message was sent while issue was closed.

Change committed as 13933

Expand Messages | Collapse Messages