Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 208313014: gather GM tests which are disabled on Android (Closed)

Created:
6 years, 9 months ago by epoger
Modified:
6 years, 9 months ago
Reviewers:
borenet, djsollen
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

gather GM tests which are disabled on Android BUG=skia:2326 Committed: http://code.google.com/p/skia/source/detail?r=13922

Patch Set 1 #

Patch Set 2 : add links to bugs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -26 lines) Patch
M gm/androidfallback.cpp View 3 chunks +0 lines, -6 lines 0 comments Download
M gm/bitmapcopy.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M gm/coloremoji.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/drawbitmaprect.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M gm/shadertext.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M gm/shadertext2.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M gm/shadertext3.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M gm/verylargebitmap.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/gmslides.gypi View 1 2 chunks +32 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
epoger
Running through 1 Android trybot + 1 non-Android trybot to confirm it acts as expected...
6 years, 9 months ago (2014-03-24 15:06:58 UTC) #1
epoger
Eric and Derek, please both take a look. The trybots indicate that this works as ...
6 years, 9 months ago (2014-03-24 18:13:41 UTC) #2
borenet
LGTM. Thanks Elliot. I think there are probably bugs filed for most of these, but ...
6 years, 9 months ago (2014-03-24 18:16:28 UTC) #3
epoger
Added links to any related bugs I could find in patchset 2. Derek, PTAL.
6 years, 9 months ago (2014-03-24 18:31:58 UTC) #4
djsollen
lgtm
6 years, 9 months ago (2014-03-24 18:35:30 UTC) #5
epoger
The CQ bit was checked by epoger@google.com
6 years, 9 months ago (2014-03-24 18:36:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/208313014/20001
6 years, 9 months ago (2014-03-24 18:36:29 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 20:07:57 UTC) #8
Message was sent while issue was closed.
Change committed as 13922

Powered by Google App Engine
This is Rietveld 408576698