Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: Source/bindings/v8/Dictionary.h

Issue 208313010: Replace raw pointers to GC allocated objects by members in stack allocated objects. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Make Dictionary allow_only_inline_alloc Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/v8/Dictionary.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/Dictionary.h
diff --git a/Source/bindings/v8/Dictionary.h b/Source/bindings/v8/Dictionary.h
index 486d5b6bec5d6f7473cafe8f8296c8b82c8b6d6f..9f0e8490ddbde559328b0dbdf22407aa2ee63d5e 100644
--- a/Source/bindings/v8/Dictionary.h
+++ b/Source/bindings/v8/Dictionary.h
@@ -59,6 +59,7 @@ class TrackBase;
class VoidCallback;
class Dictionary {
+ ALLOW_ONLY_INLINE_ALLOCATION();
public:
Dictionary();
Dictionary(const v8::Handle<v8::Value>& options, v8::Isolate*);
@@ -90,8 +91,8 @@ public:
bool get(const String&, RefPtr<MediaKeyError>&) const;
bool get(const String&, RefPtr<TrackBase>&) const;
bool get(const String&, RefPtr<SpeechRecognitionError>&) const;
- bool get(const String&, RefPtrWillBeRawPtr<SpeechRecognitionResult>&) const;
- bool get(const String&, RefPtrWillBeRawPtr<SpeechRecognitionResultList>&) const;
+ bool get(const String&, RefPtrWillBeMember<SpeechRecognitionResult>&) const;
+ bool get(const String&, RefPtrWillBeMember<SpeechRecognitionResultList>&) const;
bool get(const String&, RefPtrWillBeMember<Gamepad>&) const;
bool get(const String&, RefPtr<MediaStream>&) const;
bool get(const String&, RefPtr<EventTarget>&) const;
@@ -99,7 +100,7 @@ public:
bool get(const String&, Dictionary&) const;
bool get(const String&, Vector<String>&) const;
bool get(const String&, ArrayValue&) const;
- bool get(const String&, RefPtrWillBeRawPtr<DOMError>&) const;
+ bool get(const String&, RefPtrWillBeMember<DOMError>&) const;
bool get(const String&, OwnPtr<VoidCallback>&) const;
bool get(const String&, v8::Local<v8::Value>&) const;
@@ -178,13 +179,7 @@ public:
bool hasProperty(const String&) const;
- // Only allow inline allocation.
- void* operator new(size_t, NotNullTag, void* location) { return location; }
-
private:
- // Disallow new allocation.
- void* operator new(size_t);
-
bool getKey(const String& key, v8::Local<v8::Value>&) const;
v8::Handle<v8::Value> m_options;
« no previous file with comments | « no previous file | Source/bindings/v8/Dictionary.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698